Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace openraft with async version raft-rs #121

Merged
merged 8 commits into from
May 1, 2022
Merged

Conversation

MrCroxx
Copy link
Owner

@MrCroxx MrCroxx commented Apr 28, 2022

Replace dependency https://github.com/datafuselabs/openraft with https://github.com/mrcroxx/raft-rs (async branch).

Most new modules with components using raft-rs are named with _v2.

And the QPS of integration tests increases 20x than before with openraft.

Remove openraft deps later.

Ref: #88 #117 #118 #119

@MrCroxx MrCroxx added the enhancement New feature or request for optimization. label Apr 28, 2022
@MrCroxx MrCroxx self-assigned this Apr 28, 2022
@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #121 (8cc3d0b) into main (0a7c67d) will increase coverage by 5.39%.
The diff coverage is 80.60%.

@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
+ Coverage   73.26%   78.65%   +5.39%     
==========================================
  Files          72       85      +13     
  Lines        7294     9474    +2180     
==========================================
+ Hits         5344     7452    +2108     
- Misses       1950     2022      +72     
Impacted Files Coverage Δ
common/src/lib.rs 100.00% <ø> (ø)
common/src/log.rs 15.78% <0.00%> (-0.43%) ⬇️
storage/src/error.rs 14.28% <ø> (ø)
storage/src/lib.rs 100.00% <ø> (ø)
storage/src/lsm_tree/components/block.rs 95.32% <ø> (ø)
storage/src/raft_log_store_v2/error.rs 0.00% <0.00%> (ø)
wheel/src/components/lsm_tree.rs 84.21% <ø> (+24.88%) ⬆️
wheel/src/error.rs 0.00% <0.00%> (ø)
wheel/src/service.rs 14.25% <0.00%> (-56.18%) ⬇️
wheel/src/worker/kv.rs 46.15% <0.00%> (-15.39%) ⬇️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a7c67d...8cc3d0b. Read the comment docs.

@MrCroxx MrCroxx marked this pull request as ready for review May 1, 2022 03:50
@MrCroxx
Copy link
Owner Author

MrCroxx commented May 1, 2022

So happy to hear: image

@MrCroxx MrCroxx enabled auto-merge (squash) May 1, 2022 03:56
@MrCroxx MrCroxx merged commit 4c32bfb into main May 1, 2022
@MrCroxx MrCroxx deleted the xx/raft-rs branch May 1, 2022 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request for optimization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant