Merge pull request #29 from MrDave1999/refactor/default-values

* refactor!: Add default values to Message/Status properties

* test: Add/update tests for creating an instance with default values

* test: Exclude the Status property in the assertion 

* chore: Add a resource called Error

src/Core/Resources/ResponseMessages.es.resx

@@ -132,6 +132,9 @@
   <data name="DivideByZero" xml:space="preserve">
     <value>No se puede dividir por cero. El parámetro '{0}' no puede ser cero</value>
   </data>
+  <data name="Error" xml:space="preserve">
+    <value>Error</value>
+  </data>
   <data name="Failure" xml:space="preserve">
     <value>Se ha producido un error durante la ejecución de un servicio</value>
   </data>

src/Core/Resources/ResponseMessages.resx

@@ -132,6 +132,9 @@
   <data name="DivideByZero" xml:space="preserve">
     <value>Cannot be divided by zero. The '{0}' parameter cannot be zero</value>
   </data>
+  <data name="Error" xml:space="preserve">
+    <value>Error</value>
+  </data>
   <data name="Failure" xml:space="preserve">
     <value>An error occurred during the execution of a service</value>
   </data>

src/Core/ResultBase.cs

@@ -20,7 +20,7 @@ public abstract class ResultBase
     /// <summary>
     /// Gets the description of a result.
     /// </summary>
-    public string Message { get; init; }
+    public string Message { get; init; } = ResponseMessages.Error;
 
     /// <summary>
     /// Gets a collection of errors.
@@ -31,5 +31,5 @@ public abstract class ResultBase
     /// Gets the current status of a result.
     /// </summary>
     [JsonIgnore]
-    public ResultStatus Status { get; init; }
+    public ResultStatus Status { get; init; } = ResultStatus.Failure;
 }

tests/Json/SystemTextJson.ListedResultOfT.Tests.cs

@@ -88,7 +88,9 @@ public void ListedResultOfT_ShouldDeserializeResultOfValueType()
         var actual = JsonSerializer.Deserialize<ListedResult<int>>(json, options);
 
         // Assert
-        actual.Should().BeEquivalentTo(expectedResult);
+        actual
+            .Should()
+            .BeEquivalentTo(expectedResult, o => o.Excluding(r => r.Status));
     }
 
     [Test]
@@ -123,6 +125,8 @@ public void ListedResultOfT_ShouldDeserializeResultOfReferenceType()
         var actual = JsonSerializer.Deserialize<ListedResult<Person>>(json, options);
 
         // Assert
-        actual.Should().BeEquivalentTo(expectedResult);
+        actual
+            .Should()
+            .BeEquivalentTo(expectedResult, o => o.Excluding(r => r.Status));
     }
 }

tests/Json/SystemTextJson.PagedResultOfT.Tests.cs

@@ -117,7 +117,9 @@ public void PagedResultOfT_ShouldDeserializeResultOfValueType()
         var actual = JsonSerializer.Deserialize<PagedResult<int>>(json, options);
 
         // Assert
-        actual.Should().BeEquivalentTo(expectedResult);
+        actual
+            .Should()
+            .BeEquivalentTo(expectedResult, o => o.Excluding(r => r.Status));
     }
 
     [Test]
@@ -161,6 +163,8 @@ public void PagedResultOfT_ShouldDeserializeResultOfReferenceType()
         var actual = JsonSerializer.Deserialize<PagedResult<Person>>(json, options);
 
         // Assert
-        actual.Should().BeEquivalentTo(expectedResult);
+        actual
+            .Should()
+            .BeEquivalentTo(expectedResult, o => o.Excluding(r => r.Status));
     }
 }

tests/Json/SystemTextJson.Result.Tests.cs

@@ -43,6 +43,8 @@ public void Result_ShouldDeserializeResultWithoutData()
         var actual = JsonSerializer.Deserialize<Result>(json, options);
 
         // Assert
-        actual.Should().BeEquivalentTo(expectedResult);
+        actual
+            .Should()
+            .BeEquivalentTo(expectedResult, o => o.Excluding(r => r.Status));
     }
 }

tests/Json/SystemTextJson.ResultOfT.Tests.cs

@@ -70,7 +70,9 @@ public void ResultOfT_ShouldDeserializeResultOfValueType()
         var actual = JsonSerializer.Deserialize<Result<int>>(json, options);
 
         // Assert
-        actual.Should().BeEquivalentTo(expectedResult);
+        actual
+            .Should()
+            .BeEquivalentTo(expectedResult, o => o.Excluding(r => r.Status));
     }
 
     [Test]
@@ -95,7 +97,9 @@ public void ResultOfT_ShouldDeserializeResultOfCreatedIdType()
         var actual = JsonSerializer.Deserialize<Result<CreatedId>>(json, options);
 
         // Assert
-        actual.Should().BeEquivalentTo(expectedResult);
+        actual
+            .Should()
+            .BeEquivalentTo(expectedResult, o => o.Excluding(r => r.Status));
     }
 
     [Test]
@@ -121,6 +125,8 @@ public void ResultOfT_ShouldDeserializeResultOfCreatedGuidType()
         var actual = JsonSerializer.Deserialize<Result<CreatedGuid>>(json, options);
 
         // Assert
-        actual.Should().BeEquivalentTo(expectedResult);
+        actual
+            .Should()
+            .BeEquivalentTo(expectedResult, o => o.Excluding(r => r.Status));
     }
 }

tests/ListedResultOfT.Tests.cs

@@ -5,14 +5,19 @@ public class ListedResultOfTTests
     [Test]
     public void ListedResultOfT_ShouldCreateInstanceWithDefaultValues()
     {
+        // Arrange
+        var expectedMessage = ResponseMessages.Error;
+
         // Act
         var actual = new ListedResult<Person>();
 
         // Asserts
         actual.Data.Should().BeEmpty();
         actual.IsSuccess.Should().BeFalse();
         actual.IsFailed.Should().BeTrue();
+        actual.Message.Should().Be(expectedMessage);
         actual.Errors.Should().BeEmpty();
+        actual.Status.Should().Be(ResultStatus.Failure);
     }
 
     [Test]

tests/PagedResultOfT.Tests.cs

@@ -5,6 +5,9 @@ public class PagedResultOfTTests
     [Test]
     public void PagedResultOfT_ShouldCreateInstanceWithDefaultValues()
     {
+        // Arrange
+        var expectedMessage = ResponseMessages.Error;
+
         // Act
         var actual = new PagedResult<Person>();
 
@@ -13,7 +16,9 @@ public void PagedResultOfT_ShouldCreateInstanceWithDefaultValues()
         actual.PagedInfo.Should().BeNull();
         actual.IsSuccess.Should().BeFalse();
         actual.IsFailed.Should().BeTrue();
+        actual.Message.Should().Be(expectedMessage);
         actual.Errors.Should().BeEmpty();
+        actual.Status.Should().Be(ResultStatus.Failure);
     }
 
     [Test]

tests/ResultOfT.Tests.cs

@@ -2,6 +2,24 @@
 
 public class ResultOfTTests
 {
+    [Test]
+    public void ResultOfT_ShouldCreateInstanceWithDefaultValues()
+    {
+        // Arrange
+        var expectedMessage = ResponseMessages.Error;
+
+        // Act
+        var actual = new Result<Person>();
+
+        // Asserts
+        actual.Data.Should().BeNull();
+        actual.IsSuccess.Should().BeFalse();
+        actual.IsFailed.Should().BeTrue();
+        actual.Message.Should().Be(expectedMessage);
+        actual.Errors.Should().BeEmpty();
+        actual.Status.Should().Be(ResultStatus.Failure);
+    }
+
     [Test]
     public void ImplicitOperator_WhenConvertedFromResultType_ShouldReturnsResultOfT()
     {

tests/ResultTests.cs

@@ -2,6 +2,23 @@
 
 public partial class ResultTests
 {
+    [Test]
+    public void Result_ShouldCreateInstanceWithDefaultValues()
+    {
+        // Arrange
+        var expectedMessage = ResponseMessages.Error;
+
+        // Act
+        var actual = new Result();
+
+        // Asserts
+        actual.IsSuccess.Should().BeFalse();
+        actual.IsFailed.Should().BeTrue();
+        actual.Message.Should().Be(expectedMessage);
+        actual.Errors.Should().BeEmpty();
+        actual.Status.Should().Be(ResultStatus.Failure);
+    }
+
     [Test]
     public void Success_WhenResultIsSuccessWithMessage_ShouldReturnsResultOfT()
     {