Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #143 #145

Closed
wants to merge 1 commit into from
Closed

Fix #143 #145

wants to merge 1 commit into from

Conversation

john-psina
Copy link

My head nearly exploded as I tried to dig deeper into the problem.
Unfortunately, I'm not familiar with the code of the module and I don't know what more significant changes could affect, so I decided to make such a quick fix of the problem, which should not break anything. The bug disappears after that, but maybe this problem should be fixed more fundamentally.

P.S Sorry for closed pull request. Trying to link pull request to issue
#143

@MrThearMan
Copy link
Owner

MrThearMan commented Sep 4, 2024

This is incorrect, since it only fixes compatibility with grahene-django-extensions, my other library, but doesn't work with graphene-django's default ordering. Explained more in the issue.

Made a fix myself. Released in v0.10.1.

@MrThearMan MrThearMan closed this Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants