[pull] main from junit-team:main #130
Open
+51,732
−17,117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This allows parameterized tests to fail when there are more arguments provided than declared by the test method. This is done in a backwards compatible way by only enabling that validation when the new `junit.jupiter.params.argumentCountValidation` configuration parameter is set to `strict` or `ParameterizedTest#argumentCountValidation` is set to `ArgumentCountValidationMode.STRICT`. Resolves #3708. --------- Co-authored-by: Marc Philipp <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Moreover, tests will now fail when new deprecation warnings are emitted.
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
When a user has the JAVA_TOOL_OPTIONS set in their environment, java will print "Picked up JAVA_TOOL_OPTIONS: ..." on the error stream This leads to failure in some of the Platform Tooling Tests Co-authored-by: Marc Philipp <[email protected]>
Prior to this commit, `ConsoleLauncher` created `PrintWriters` that wouldn't flush automatically when `println` is called which stopped the `testfeed` details mode from being useful. Moreover, it didn't initialized them with the right `Charsets`. Now, we rely on Picocli's initialization again which does both correctly.
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Prior to this commit, Maven builds triggered from integration tests sometimes failed because another concurrent build was writing to the same file in the temporary local Maven repo.
This causes problems on IntelliJ IDEA's 2025.1 EAP version which picks the IDE's own JetBrains JDK rather than one specified using the `JDK21` env var. Since JetBrains' JDK does not contain tools like `jar` this causes builds to break when the Gradle daemon is started via IntelliJ IDEA. This reverts commit 1e29d8e.
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This reverts commit 7b4b972.
Prior to this commit, a `DisplayNameGenerator` could access the type of a `@Nested` test class as well as the enclosing class in which a `@Nested` test class is declared, but it could not access the concrete runtime type of the enclosing instance for a `@Nested` test class. When a `DisplayNameGenerator` is used to build hierarchical display names, this could lead to confusing results or even conflicting results depending on the structure of the test classes used, "conflicting" in the sense that two nested test classes may have identical display names that do not represent the runtime structure of the test classes. Now, each `DisplayNameGenerator` receives the list of enclosing instance types when computing the display name of a nested test class or test method. Resolves #4130. --------- Co-authored-by: Sam Brannen <[email protected]>
Make API consistent with `DisplayNameGenerator` prior to releasing it in 5.12. Resolves #4163. --------- Co-authored-by: Sam Brannen <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
The `@TempDir` annotation on a constructor parameter is copied to the generated `final` instance field. This caused it top be picked up by `TempDirectory` for instance field injection which then failed because the field was `final`. This change now checks if a test class is an instance of a record type and skips instance field injection. Since records cannot have any instance fields besides the ones generated from their constructor, there's no need to inject values into any of them.
Prior to this commit, the `DisplayNameGeneration` annotation was discovered on the current test, a superclass, or the enclosing class in which a `Nested` test class is declared. However, the runtime type of an enclosing instance is not always identical to the class in which the `Nested` test class was declared. This caused annotations on runtime enclosing types to be missed when checking for them in `IndicativeSentences` which resulted in unexpected display names. Now, the runtime enclosing types are checked rather than the compile-time ones. Resolves #4131. --------- Co-authored-by: Sam Brannen <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )