Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sort by column. Force all columns headers to be initialized. #633

Closed
wants to merge 32 commits into from

Conversation

gh-devnull
Copy link
Contributor

No description provided.

gh-devnull and others added 30 commits April 6, 2023 16:45
Extend DiffTool, MergeTool, EditTool, and ShowTool to support
one or more files in each tool.
Avoid the inconvenience of having to close the drop-down list manually after checking out a branch.

...and format...
Using the workspace file as "merged" allows for the file to be edited in-place for the merge.
…r from the QProcess constructor for DiffTool.cpp, EditTool.cpp, and MergeTool.cpp so the external tool process lifetimes are not in anyway tied to gittup's lifetime. This simulates QProcess::startDetached() behavior.
…r from the QProcess constructor for DiffTool.cpp, EditTool.cpp, and MergeTool.cpp so the external tool process lifetimes are not in anyway tied to gittup's lifetime. This simulates QProcess::startDetached() behavior.
…eration.

When a directory is selected, all files within it, recursively, are added to the list of 
files selected.  This is not really what the user intends (i.e. if the files are displayed 
as a tree and the user selects from the first to the last, the user really only wants to 
interact with the selected files, not all those in any selected directory).  

Introduce the AccumRepoFiles class to keep track of files actually selected by the user 
as well as those under any selected directory and provide a way to get either list 
individually or both file lists together.
3c92cc0 ("Adds "Hide Untracked Files" option to DoubleTreeWidget cogwheel context menu", 2023-07-02) pvacatel
a80ffed ("Fixes code format according to clang-format", 2023-07-03) pvacatel
b202f1a ("Reverts format changes to test/Settings.cpp", 2023-07-04) pablov
0a935f8 ("enable debug build by setting a settings Reason: so the debug possibility is always available and is by default off for performance reason", 2023-07-14) Martin Marmsoler
198fb7a ("Update src/app/Application.cpp", 2023-07-14) Martin Marmsoler
1e57e7d ("Spanish translation", 2023-06-17) José Miguel Manzano 
3c92cc0 ("Adds "Hide Untracked Files" option to DoubleTreeWidget cogwheel context menu", 2023-07-02) pvacatel
a80ffed ("Fixes code format according to clang-format", 2023-07-03) pvacatel
b202f1a ("Reverts format changes to test/Settings.cpp", 2023-07-04) pablov
0a935f8 ("enable debug build by setting a settings Reason: so the debug possibility is always available and is by default off for performance reason", 2023-07-14) Martin Marmsoler
198fb7a ("Update src/app/Application.cpp", 2023-07-14) Martin Marmsoler
…as a list in TreeViews. Resolves Dense layout issue Murmele#547
@Murmele
Copy link
Owner

Murmele commented Oct 4, 2023

The tests are failing

@gh-devnull
Copy link
Contributor Author

Hm. Looks like they are coming from commits that aren't mine - might be a bad merge.

OK, ignore this for now while I see how to get a branch with just my commit.

#632 builds OK and has successful tests (if you exclude the complaint about QT not installing on Windows - I have no idea what that's about). Since this one builds on that, maybe it makes sense to focus on that first.

@Murmele
Copy link
Owner

Murmele commented Oct 8, 2023

On Linux:

The following tests FAILED:
17 - TreeView (Failed)
23 - fileContextMenu (Failed)

@Murmele
Copy link
Owner

Murmele commented Nov 12, 2023

@gh-devnull Can you clean this up?

@Murmele
Copy link
Owner

Murmele commented Nov 12, 2023

Is this still needed when merging #664 ?

@Murmele Murmele marked this pull request as draft November 12, 2023 18:24
@gh-devnull
Copy link
Contributor Author

Agreed. #664 includes this functionality. I've closed this as a result.

@gh-devnull gh-devnull closed this Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants