Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrent hermes #10

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Concurrent hermes #10

merged 1 commit into from
Mar 27, 2024

Conversation

TonyGiorgio
Copy link
Contributor

Should be able to run multiple concurrent hermes at once.

@TonyGiorgio TonyGiorgio merged commit cc166a8 into master Mar 27, 2024
2 checks passed
@TonyGiorgio TonyGiorgio deleted the fly-hermes-concurrent branch March 27, 2024 01:41
@benthecarman
Copy link
Contributor

This might cause problems because it'll start the subscription for all the pending invoices on startup. Maybe it's fine to just disable that?

if let Err(e) = handle_pending_invoices(&cloned_state).await {

@TonyGiorgio
Copy link
Contributor Author

I don't think a little redundancy is going to hurt anything.

@benthecarman
Copy link
Contributor

my main concern is that it sends double notifications

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants