Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MCR-3313 revise access key service and endpoint #2217

Merged

Conversation

golsch
Copy link
Member

@golsch golsch commented Jul 31, 2024

@golsch golsch marked this pull request as draft July 31, 2024 15:00
@golsch golsch force-pushed the issues/MCR-3157_revise_access_key_service_and_endpoint branch 28 times, most recently from 6446a03 to 7b312eb Compare August 7, 2024 16:45
@golsch golsch force-pushed the issues/MCR-3157_revise_access_key_service_and_endpoint branch 4 times, most recently from 8aa70e2 to 9583110 Compare November 8, 2024 10:48
@golsch golsch force-pushed the issues/MCR-3157_revise_access_key_service_and_endpoint branch 2 times, most recently from d6d52d0 to f1611fd Compare November 19, 2024 15:44
@golsch golsch force-pushed the issues/MCR-3157_revise_access_key_service_and_endpoint branch 4 times, most recently from 0b35955 to 871b961 Compare November 19, 2024 16:35
@golsch golsch force-pushed the issues/MCR-3157_revise_access_key_service_and_endpoint branch from 871b961 to 21f8b14 Compare November 19, 2024 16:40
@kkrebs
Copy link
Contributor

kkrebs commented Dec 5, 2024

@yagee-de @rsteph-de - we like to merge this into 2024.06 asap
can you please have one more look at this?

  • org.mycore.mcr.acl.accesskey.access
  • org.mycore.mcr.acl.accesskey.restapi.v2
  • org.mycore.mcr.acl.accesskey.restapi.v2.access

Copy link
Member

@rsteph-de rsteph-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for me

@yagee-de
Copy link
Member

Please open another ticket for this PR, as this PR didn't make it into the release and other PRs for MCR-3157 were already merged.

@golsch golsch changed the title MCR-3157 revise access key service and endpoint MCR-3313 revise access key service and endpoint Jan 7, 2025
@yagee-de yagee-de merged commit 3f76f70 into 2024.06.x Jan 14, 2025
4 checks passed
@yagee-de yagee-de deleted the issues/MCR-3157_revise_access_key_service_and_endpoint branch January 14, 2025 13:51
yagee-de added a commit that referenced this pull request Jan 20, 2025
* 2024.06.x:
  MCR-3285 pmd: UnsynchronizedStaticFormatter (#2344)
  MCR-3288 PMD avoid filestream's (#2362)
  MCR-3279 Enable PMD rule UseProperClassLoader
  MCR-3293 Enable PMD rule category/java/performance.xml/UseIndexOfChar (#2360)
  MCR-3227 enable PMD rule GuardLogStatement (#2349)
  MCR-3202 vite processing ui (#2351)
  MCR-3291 PMD rule RedundantFieldInitializer (#2361)
  MCR-3313 fixed pmd issues (#2359)
  MCR-3313 revise access key service and endpoint (#2217)
  MCR-3231 enable PMD rule MissingOverride
  MCR-3228 remove tests in production code
  MCR-3238 pmd: UseEnumCollections (#2350)
  MCR-3265 pmd: CloneMethodMustBePublic (#2346)
  MCR-3271 pmd: NonStaticInitializer (#2345)
  MCR-3294 pmd: UseStringBufferForStringAppends (#2342)
  MCR-3252 pmd: UseShortArrayInitializer
  MCR-3260 pmd: UselessOverridingMethod
  MCR-3284 pmd: NonThreadSafeSingleton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants