[CLEANUP] Drop empty OutputFormat constructor
#1127
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverklee
added this to the 9.0.0: Drop support for PHP < 7.2 and clean up things milestone
JakeQZ
reviewed
Mar 9, 2025
There was a problem hiding this comment.
If a user extends OutputFormat (for what reason, I don't know), this could be a breaking change, since calling parent::construct() requires a constructor to be explicitly defined.
So I think we might first need to deprecate OutputFormat being extensible. Then, when removing the constructor, also make it final.
oliverklee
force-pushed
the
cleanup/drop-of-constructor
branch
from
1a4ae12 to
6f39f0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.