Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Revert broken support for multiple comments #740

Merged
merged 2 commits into from
Oct 24, 2024
Merged

[BUGFIX] Revert broken support for multiple comments #740

merged 2 commits into from
Oct 24, 2024

Conversation

oliverklee
Copy link
Contributor

This reverts e4c66f6 (#672), which broke comment parsing in strict mode.

We'll need to re-implement support for multiple comments later in a way that does not break the existing comment parsing.

@oliverklee
[BUGFIX] Revert broken support for multiple comments
a1a9a61 
This reverts e4c66f6 (#672), which
broke comment parsing in strict mode.

We'll need to re-implement support for multiple comments later
in a way that does not break the existing comment parsing.
@oliverklee oliverklee self-assigned this Oct 23, 2024
@coveralls
Copy link

coveralls commented Oct 23, 2024 •
edited
Loading

Coverage Status

coverage: 38.622% (-0.03%) from 38.652%
when pulling 9bfa67f on bugfix/comments
into e2bb6b7 on main.

JakeQZ
JakeQZ reviewed Oct 23, 2024
View reviewed changes
Copy link
Contributor

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find. I have a couple of queries re reverting the change.

CHANGELOG.md Outdated Show resolved Hide resolved
tests/ParserTest.php Outdated Show resolved Hide resolved
@oliverklee
Copy link
Contributor Author

I've applied the suggested changes and repushed.

@JakeQZ JakeQZ merged commit a5a1f1a into main Oct 24, 2024
20 checks passed
@JakeQZ JakeQZ deleted the bugfix/comments branch October 24, 2024 15:45
oliverklee added a commit that referenced this pull request Oct 24, 2024
@oliverklee
[BUGFIX] Revert broken support for multiple comments
09635e6 
This reverts e4c66f6 (#672), which broke comment parsing in
strict mode.

We'll need to re-implement support for multiple comments later
in a way that does not break the existing comment parsing.

This is the v8.x backport of #740.
@oliverklee oliverklee mentioned this pull request Oct 24, 2024
Merged
JakeQZ pushed a commit that referenced this pull request Oct 24, 2024
@oliverklee
[BUGFIX] Revert broken support for multiple comments (#741)
81582a7 
This reverts e4c66f6 (#672), which broke comment parsing in
strict mode.

We'll need to re-implement support for multiple comments later
in a way that does not break the existing comment parsing.

This is the v8.x backport of #740.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

@sabberworm sabberworm Awaiting requested review from sabberworm

Assignees

@oliverklee oliverklee

Labels
bug to-backport
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverklee @coveralls @JakeQZ