[CLEANUP] Autoformat the code #749
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeQZ
requested changes
Oct 26, 2024
There was a problem hiding this comment.
I'm sure PHP-Fixer added the spaces after cast operators (somewhat against my taste). So we shouldn't be removing them again.
There's a string with arbitrary whitespace that needs manual post-reformatting to make it readable again.
Shouldn't the autoformat be done first on main?
Comment on lines
+47
to
+48
| ', | ||
| ], |
There was a problem hiding this comment.
The leading and trailing whitespace is arbitrary, and for readability. So the string content and closing quote should now be futher indented.
tests/Value/ValueTest.php
Outdated
| @@ -39,7 +39,7 @@ public function parsesArithmeticInFunctions($operator) | |||
| { | |||
| $subject = Value::parseValue(new ParserState('max(300px, 50vh ' . $operator . ' 10px);', Settings::create())); | |||
|
|
|||
| self::assertSame('max(300px,50vh ' . $operator . ' 10px)', (string) $subject); | |||
| self::assertSame('max(300px,50vh ' . $operator . ' 10px)', (string)$subject); | |||
There was a problem hiding this comment.
This surely contradicts PHP-Fixer, which added spaces after casts.
oliverklee
force-pushed
the
backport/autoformat
branch
from
7353634
to
e6c77d7
Compare
Yes: #748 I'll mark this PR here as draft for now and do the corresponding changes there. |
oliverklee
force-pushed
the
backport/autoformat
branch
from
e6c77d7
to
1d5e320
Compare
This is the v8.x backport of #748.
oliverklee
force-pushed
the
backport/autoformat
branch
from
1d5e320
to
7745173
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the v8.x backport of #748.