-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLEANUP] Autoformat the code #749
base: v8.x
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sure PHP-Fixer added the spaces after cast operators (somewhat against my taste). So we shouldn't be removing them again.
There's a string with arbitrary whitespace that needs manual post-reformatting to make it readable again.
Shouldn't the autoformat be done first on main
?
', | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The leading and trailing whitespace is arbitrary, and for readability. So the string content and closing quote should now be futher indented.
tests/Value/ValueTest.php
Outdated
@@ -39,7 +39,7 @@ public function parsesArithmeticInFunctions($operator) | |||
{ | |||
$subject = Value::parseValue(new ParserState('max(300px, 50vh ' . $operator . ' 10px);', Settings::create())); | |||
|
|||
self::assertSame('max(300px,50vh ' . $operator . ' 10px)', (string) $subject); | |||
self::assertSame('max(300px,50vh ' . $operator . ' 10px)', (string)$subject); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This surely contradicts PHP-Fixer, which added spaces after casts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
7353634
to
e6c77d7
Compare
Yes: #748 I'll mark this PR here as draft for now and do the corresponding changes there. |
e6c77d7
to
1d5e320
Compare
This is the v8.x backport of #748.
1d5e320
to
7745173
Compare
This is the v8.x backport of #748.