Add strikethrough support #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR.
About your comment, I think the approach is valid, but it will probably be better to keep the original text as it is. The same approach with the tables in #276 |
MihailsKuzmins
requested changes
Nov 20, 2024
tests/MudBlazor.Markdown.Tests/MarkdownComponentTests/MarkdownComponentShould.cs
Outdated
Show resolved
Hide resolved
|
Requested changes made :) |
MihailsKuzmins
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple change, but the code might need more refactoring as currently if any invalid emphasis is detected, the entire text rendering is skipped. I'd like to have it so that invalid/unsupported emphasis is drawn with a red background so that it is clearer to the user when errors happen instead of just hiding the text completely. That feature was out of the scope of this PR, though I can add it in a separate PR if this idea sounds like something worth pursuing.