fix(sui-move): sui move new command fails with os error 2 if using <NAME> with uppercase letter(s)
#21313
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AME> with uppercase letter(s)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
mdgeorge4153
approved these changes
Feb 24, 2025
Hi @mdgeorge4153, do you mean adding an integration test under |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a new Move package with the
sui move newcommand using only the required argument<NAME>fails withNo such file or directory (os error 2)if<NAME>contains uppercase letter(s).Porting over iotaledger/iota/issues/4895.
Description
Describe the changes or additions included in this PR.
<NAME>instead of its lowercase variant to obtain the correct and existing path for writing.<NAME>validation error message: since<NAME>is validated as anIdentifier, a valid<NAME>can also start with an uppercase letter or underscore.Test plan
How did you test the new or updated feature?
The issue can be tested before and after the proposed changes as follows:
Note
The issue seems to be reproducible only on Linux.
On MacOS, the bug might not be reproducible due to MacOS default case-insensitivity.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.