refactor(rpc-alt): pass configs via Context #21332
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description Small tweak on config files -- it's already in the config so we don't need to add the suffix here. ## Test plan CI
## Description Gather all the configs together and expose them through the `Context`, rather than handing out the configs needed to each module as a field. The motivation for this came from working on Display -- part of handling object responses, which shows up across multiple RPC modules (objects, query objects, dynamic fields), but deeply nested in the call stack and requires some configuration. With the old method of propagating configs, we would need to make the display config available to all the modules that handle object responses and thread it through the function call stack, even if e.g. dynamic fields use object responses but never ask for Display. With this new system, we piggy-back on the fact that the `Context` parameter is already threaded into all these functions. ## Test plan ``` sui$ cargo nextest run \ -p sui-indexer-alt-jsonrpc \ -p sui-indexer-alt-e2e-tests ```
## Description Standardise the order of imports, to help `rust-analyzer` maintain it consistently in future: - Order imports as follows: `std`, dependencies, `crate`, `super`, `self`. - Group together the `crate` and `super` imports at the top-level. ## Test plan CI
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
amnn
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A couple of refactorings, mostly to do with configs:
Contextwhere all modules can access it. The motivation for this came from working onshowDisplaywhich is relevant to a multiple modules but is quite deeply nested, so threading the config into the right place became quite tedious/noisy.RpcConfiginto anRpcLayerandRpcConfig-- this was so that theContextcould hold on to one value (ofRpcConfig) rather than having to pass each module's config to it individually (and access them individually through their own modifiers).rpc-altcodebase, to follow a standard order and style (not a big deal, but seeing as I noticed, I thought I would clean it up): imports are grouped by their top-level identifier, and we order imports as follows (with a blank line between each group):std::, dependency imports,crate::,super::,self::.Test plan
CI
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.