fix: fix incorrect handling of MutexGuard and HashMap removal

[hexcow]

Description

I noticed an issue where the code wasn't properly handling the removal of an item from the HashMap wrapped in a MutexGuard. The fix ensures that we first acquire the MutexGuard to access the HashMap and then call .remove() on it. This avoids potential issues with concurrent access and ensures the correct behavior.

Changes:

• Called self.pending(key) to get the MutexGuard wrapping the HashMap.
• Used .remove() on the HashMap to properly remove the item.
• Added a check to ensure registrations is not empty before proceeding.

Test plan

1. Verify that the HashMap removal logic works as expected in a single-threaded context.
2. Test the fix in a multi-threaded environment to ensure no race conditions occur.
3. Add unit tests to cover the scenario where registrations is both present and absent.

Release notes

• Protocol: No changes.
• Nodes (Validators and Full nodes): No changes.
• gRPC: No changes.
• JSON-RPC: No changes.
• GraphQL: No changes.
• CLI: No changes.
• Rust SDK: Fixed incorrect handling of MutexGuard and HashMap removal to ensure thread safety.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
sui-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 25, 2025 11:38am

2 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
multisig-toolkit	⬜️ Ignored (Inspect)	Visit Preview		Feb 25, 2025 11:38am
sui-kiosk	⬜️ Ignored (Inspect)	Visit Preview		Feb 25, 2025 11:38am