Issue #507 - Fix invalid content validation check in base val.py classes #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update base Validator.content_val to return a proper default value. Validation that doesn't include a custom `content_val` implementation relies on this default implementation during validation checks. By default, that includes EVR and Limit dictionary checks. The current implementation incorrect returns a garbage value (None) for the default implementation. Documentation of the default `content_val` method has been updated to elaborate on why it's making the current check and what a more thorough implementation looks like. Tangentially related, error handling around schema validation was a bit lacking. This also includes minor updates around the `schema_val` checks in `Validator` to better handle and log exceptions related to that. Additionally, validation is short circuited if failures occur there to avoid confusing error messages in unrelated `content_val` checks.
nttoole
approved these changes
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update base Validator.content_val to return a proper default value. Validation that doesn't include a custom
content_valimplementation relies on this default implementation during validation checks. By default, that includes EVR and Limit dictionary checks. The current implementation incorrectly returns a garbage value (None) for the default implementation.Documentation of the default
content_valmethod has been updated to elaborate on why it's making the current check and what a more thorough implementation looks like.Tangentially related, error handling around schema validation was a bit lacking. This also includes minor updates around the
schema_valchecks inValidatorto better handle and log exceptions related to that. Additionally, validation is short circuited if failures occur there to avoid confusing error messages in unrelatedcontent_valchecks.Resolve #507