Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main into feature/capgen (merge after #493) #499

Merged
merged 91 commits into from
Sep 21, 2023
Merged

Commits on Jul 19, 2021

  1. Configuration menu
    Copy the full SHA
    3fa6b4c View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2021

  1. Update scripts/ccpp_prebuild.py and scripts/mkstatic.py to create she…

    …ll and cmake include files for the static API
    climbfuji committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    d8d98a2 View commit details
    Browse the repository at this point in the history
  2. Add CCPP stub

    climbfuji committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    2adecf3 View commit details
    Browse the repository at this point in the history
  3. Add stub/README.md

    climbfuji committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    958b284 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2021

  1. Configuration menu
    Copy the full SHA
    f2619d9 View commit details
    Browse the repository at this point in the history
  2. A few structure changes, add function for parsing arguments and check…

    …ing variable against standard names
    mkavulich committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    2f209a5 View commit details
    Browse the repository at this point in the history
  3. Change "xml" to "sdf" to better reflect other script conventions, fle…

    …sh out argument parsing routine more
    mkavulich committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    5715006 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4160be2 View commit details
    Browse the repository at this point in the history
  5. Create new method and attribute for Suite class that creates a call t…

    …ree for that Suite:
    
    in other words, a list of schemes in the order that they are called, including duplicates
    and subcycle loops
    mkavulich committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    e9da740 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    31245e1 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    83f733f View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    6cb14c9 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    0ceb853 View commit details
    Browse the repository at this point in the history
  10. Need to add call to gather_variable_definitions in order to get new m…

    …etadata converted properly (?)
    mkavulich committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    a332867 View commit details
    Browse the repository at this point in the history
  11. Finally got to where I thought I should be! I now have a calling tree…

    … of schemes for a given SDF, and a dictionary that associates those schemes with their corresponding .meta files. Last step is to simply parse those .meta files for their variables!
    mkavulich committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    e64dbe3 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2021

  1. Getting close to finished now; using parse_metadata_file to return Me…

    …tadataTable objects for each scheme's .meta file; these objects can then be parsed to get all the information we need for the final step!
    mkavulich committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    64dad53 View commit details
    Browse the repository at this point in the history
  2. Find if variable matches in subroutine, if so, output variable name, …

    …subroutine name, and intent. If partial match, output list of partial matches
    mkavulich committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    67229d2 View commit details
    Browse the repository at this point in the history
  3. Working prototype complete! The script now takes in an SDF, config fi…

    …le, variable name, and directory with metadata files, and outputs a list of schemes that use the given variable, along with their intent. Will convert into a more "graph-like" output later, along with other cleanup that is needed before review/testing by the group.
    mkavulich committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    36a23e6 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2021

  1. Configuration menu
    Copy the full SHA
    5f9e029 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5e03756 View commit details
    Browse the repository at this point in the history
  3. Add new "--draw" argument and a stub (for now) subroutine that will g…

    …ive a graphical representation of the calling tree
    
    Also some more cleanup:
     - Change default logging level to WARNING to get rid of unnecessary log messages (debug level remains unchanged)
     - Change more strings to f strings
     - Remove more leftover debug printouts
     - Raise exception if create_metadata_filename_dict fails (esp for no .meta files found)
     - Remove check_var function (might re-introduce in the future)
    mkavulich committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    8ec769d View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2021

  1. Configuration menu
    Copy the full SHA
    6c7cfe9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9fa53bb View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2022

  1. Restore CODEOWNERS file

    climbfuji committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    3d2f7cd View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2022

  1. Change standard_name and unit of CCPP error flag variable in ccpp_pre…

    …build scripts, correct unit for ccpp_constant_one in ccpp_prebuild scripts
    climbfuji committed Jan 16, 2022
    Configuration menu
    Copy the full SHA
    db3b9c1 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2022

  1. Merge branch 'feature/capgen' of https://github.com/NCAR/ccpp-framework

    … into ccpp_error_code_in_prebuild
    climbfuji committed Jan 17, 2022
    Configuration menu
    Copy the full SHA
    96bebbf View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2022

  1. Configuration menu
    Copy the full SHA
    fee2198 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #428 from climbfuji/ccpp_error_code_in_prebuild

    ccpp_prebuild: Update CCPP metadata for error flag variable and constant one
    climbfuji authored Jan 26, 2022
    Configuration menu
    Copy the full SHA
    a55457f View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2022

  1. Configuration menu
    Copy the full SHA
    e58c284 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    566916d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d64a0fb View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2022

  1. Configuration menu
    Copy the full SHA
    503f43d View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2022

  1. Merge branch 'main' of https://github.com/NCAR/ccpp-framework into cc…

    …pp_framework_stub_merged_20220202
    climbfuji committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    4885561 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2022

  1. Configuration menu
    Copy the full SHA
    6c840e2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    302cb1e View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2022

  1. Configuration menu
    Copy the full SHA
    bd87694 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c2012ba View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    08c2027 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    566e485 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9e6b59a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    bc6963a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    1193e44 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2022

  1. A few more fixes from pylint, remove redundant "action='store_true'" …

    …from add_argument calls
    mkavulich committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    c7cc6e4 View commit details
    Browse the repository at this point in the history
  2. Move parsing of command-line arguments to "parse_arguments" function,…

    … remove re-assignment of arguments and just manage them with "args" object
    mkavulich committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    12d9078 View commit details
    Browse the repository at this point in the history
  3. Add a bit more information about call to "gather_variable_definitions…

    …" function from ccpp_prebuild
    mkavulich committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    ee99e7e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b8654c4 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5f545d7 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2022

  1. Merge pull request #438 from climbfuji/feature/fix_mkdoc

    Fix metadata2html.py, add some more documentation to ccpp_prebuild.py
    climbfuji authored Mar 11, 2022
    Configuration menu
    Copy the full SHA
    8577ea3 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2022

  1. Configuration menu
    Copy the full SHA
    65eed35 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2022

  1. Suggestion from Dom: move creation of scheme call tree to "parse" met…

    …hod of Suite class with an optional argument to avoid duplicating existing code while not affecting existing calls to parse method.
    mkavulich committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    c27f06f View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2022

  1. Configuration menu
    Copy the full SHA
    3a359da View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2022

  1. Configuration menu
    Copy the full SHA
    301c6fb View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2022

  1. Configuration menu
    Copy the full SHA
    bae5d42 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2022

  1. Configuration menu
    Copy the full SHA
    79fe851 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2022

  1. Configuration menu
    Copy the full SHA
    f8e5956 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4393986 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2022

  1. Merge pull request #443 from climbfuji/feature/remove_ccpp_api

    Remove legacy src/ccpp_api.F90 - contains #445 (fix metadata2html.py) and #447 (remove NEMSfv3gfs test scripts)
    climbfuji authored Apr 12, 2022
    Configuration menu
    Copy the full SHA
    e200083 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2022

  1. Configuration menu
    Copy the full SHA
    425cc4f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5c21306 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2022

  1. Configuration menu
    Copy the full SHA
    3f1dd5b View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2022

  1. Configuration menu
    Copy the full SHA
    8663671 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2022

  1. Merge pull request #449 from climbfuji/feature/release_debug_only

    Remove custom "BitForBit" (aka REPRO) mode
    climbfuji authored May 3, 2022
    Configuration menu
    Copy the full SHA
    c95101b View commit details
    Browse the repository at this point in the history

Commits on May 4, 2022

  1. Merge branch 'main' of https://github.com/ncar/ccpp-framework into cc…

    …pp_framework_stub_merged_20220202
    climbfuji committed May 4, 2022
    Configuration menu
    Copy the full SHA
    5fe0dc7 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2022

  1. Configuration menu
    Copy the full SHA
    948b620 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2022

  1. Merge pull request #419 from mkavulich/feature/track_variables_throug…

    …h_suite
    
    Add initial version of ccpp_track_variables.py
    grantfirl authored May 11, 2022
    Configuration menu
    Copy the full SHA
    1968d57 View commit details
    Browse the repository at this point in the history
  2. Update to track_variables script: Instead of an ordered list of schem…

    …es based on the xml file,
    
    output a list of schemes broken down by group (since groups can be called in different orders
    based on the logic in the host model)
    mkavulich committed May 11, 2022
    Configuration menu
    Copy the full SHA
    0778341 View commit details
    Browse the repository at this point in the history
  3. Bug fix: did not account for fact that some meta files contain inform…

    …ation for multiple schemes, which led to incorrect duplication of schemes listed in output
    mkavulich committed May 11, 2022
    Configuration menu
    Copy the full SHA
    00c05a1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6212965 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2022

  1. scripts/mkcap.py: Add capability to specify variable definitions for …

    …interface variables with explicit lower bounds
    climbfuji committed May 20, 2022
    Configuration menu
    Copy the full SHA
    ad6ddcb View commit details
    Browse the repository at this point in the history
  2. scripts/mkstatic.py: Handle additional dimensions required by parent …

    …variables and use explicit lower bounds in variable definitions for interface variables
    climbfuji committed May 20, 2022
    Configuration menu
    Copy the full SHA
    f83286f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    64f8054 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2022

  1. Merge pull request #451 from mkavulich/feature/improve_track_variables

    Bug fix and improvement for ccpp_track_variables tool
    grantfirl authored May 25, 2022
    Configuration menu
    Copy the full SHA
    32afb97 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2022

  1. Update README.md

    Update README links for v6
    mkavulich authored Jun 3, 2022
    Configuration menu
    Copy the full SHA
    5efe656 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2022

  1. Configuration menu
    Copy the full SHA
    f694a99 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e107542 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #436 from climbfuji/ccpp_framework_stub_merged_202…

    …20202
    
    ccpp_prebuild: ccpp stub and various bugfixes
    climbfuji authored Jun 9, 2022
    Configuration menu
    Copy the full SHA
    167313e View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2022

  1. Merge pull request #453 from NCAR/Update-README-to-v6

    Update README links for v6
    grantfirl authored Jun 14, 2022
    Configuration menu
    Copy the full SHA
    9de5b27 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2022

  1. Configuration menu
    Copy the full SHA
    c3f81f3 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2022

  1. Merge pull request #452 from climbfuji/feature/iap_dom

    Update ccpp_prebuild to support IAP model
    climbfuji authored Aug 4, 2022
    Configuration menu
    Copy the full SHA
    4daaa24 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2022

  1. Configuration menu
    Copy the full SHA
    acd3b32 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2022

  1. Merge pull request #455 from mkavulich/limit_cap_names

    Limit suite names to 37 characters or less
    mkavulich authored Oct 11, 2022
    Configuration menu
    Copy the full SHA
    d4a0003 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2022

  1. Update scripts/ccpp_state_machine.py and scripts/state_machine.py to …

    …work with Python 3.11: global inline flags in the middle of regular expressions are deprecated since Python 3.6, and no longer supported in Python 3.11
    climbfuji committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    24bab13 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ada1737 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2023

  1. Merge pull request #456 from climbfuji/bugfix/python311_global_flags

    Fix ccpp-framework errors with Python 3.11
    climbfuji authored Jan 6, 2023
    Configuration menu
    Copy the full SHA
    1b6352f View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2023

  1. Fix error message for unit conversions involving unit "1" (#462)

    * Fix error message for unit conversions involving unit "1"
    
    * Add unit tests for function string_to_python_identifier()
    mkavulich authored Mar 10, 2023
    Configuration menu
    Copy the full SHA
    60295ad View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2023

  1. Add more unit tests for routines in common.py (#465)

    This PR is a demo to begin adding more unit test coverage to the CCPP-framework. Since a unit test was recently added for the test_string_to_python_identifier function in common.py, I added unit tests for the remaining functions in that file.
    
    To run these unit tests, simply navigate to the test/unit_tests directory and run the script (with Python 3.7 or higher):
    
    $ python test_common.py 
    .....
    ----------------------------------------------------------------------
    Ran 5 tests in 0.023s
    
    OK
    
    Co-authored-by: goldy <[email protected]>
    mkavulich and gold2718 authored Apr 10, 2023
    Configuration menu
    Copy the full SHA
    625a456 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. Support multiple concurrent instances per MPI task (#463)

    In order to have an ensemble of model instances in a JEDI executable, we
    need for packages the model relies on to be “stateless” – meaning
    that the data for an instances are not shared between instances. A more
    comprehensive solution would be to implement physics so that all such
    data is either passed in via arguments to the package, or allocated as
    an instance of a class defining the physics.
    
    Deferring the larger issue of revisiting CCPP requirements to cover
    support for concurrent instances, this PR takes a more modest approach. It
    adds a new "instance" dimension to the types already defined for GFS
    physics (GFS_control, GFS_data, GFS_interstitial). And it includes some
    changes that were needed to address first-time initialization latches
    inside certain packages.
    
    One of these, in Thompson MP, declears the heap allocated fields by ccpp
    instance. The issue here was that only the first instance of Thompson
    MP was initializing itself. The other guards against trying to allocate
    data that has already been allocated (e.g. h2ointerp and ozinterp).
    
    The extent of packages touched by the PR is only one NRL-used suite that
    is a subset of all the packages in CCPP.
    michalakes authored Jun 20, 2023
    Configuration menu
    Copy the full SHA
    57d268c View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. Configuration menu
    Copy the full SHA
    210a936 View commit details
    Browse the repository at this point in the history
  2. Bug fix in ccpp_prebuild: remove harcoded name of ccpp_t variable, us…

    …e information from host model
    climbfuji committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    992b704 View commit details
    Browse the repository at this point in the history
  3. Bug fix in test/unit_tests/test_common.py: use os.path.abspath for co…

    …rrect path to TEST_FILE
    climbfuji committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    64ba62b View commit details
    Browse the repository at this point in the history
  4. Merge pull request #498 from climbfuji/feature/remove_ccpp_hardcoded_…

    …name_and_update_stub
    
    (main) ccpp_prebuild: fix hardcoded name of ccpp_t host variable, update CCPP stub, fix capgen unit tests
    climbfuji authored Sep 7, 2023
    Configuration menu
    Copy the full SHA
    3a8f278 View commit details
    Browse the repository at this point in the history