UFS-dev PR#226 #1097
Merged
UFS-dev PR#226 #1097
+52
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added hflx_fire and evap_fire to GFS_surface_composite_post * added cpl_fire flag
* added fsmoke tracer * added surface emissions to fsmoke in rrfs_smoke_wrapper
Fixes Intel LLVM compiler (ifx) error: physics/Interstitials/UFS_SCM_NEPTUNE/gcycle.F90(237): error #8284: If the actual argument is scalar, the dummy argument shall be scalar unless the actual argument is of type character or is an element of an array that is not assumed shape, pointer, or polymorphic. [SIG1T] CALL SFCCYCLE (9998, npts, max(lsoil,lsoil_lsm), sig1t, fhcyc, & -----------^
Add fire coupling into ccpp physics including heat flux, upward specific humidity flux, and smoke tracer
add Rhae Sung Kim to CODEOWNERS file
Support Intel LLVM compiler (ifx)
…nd it will be consistent with convective precipitation"
grantfirl
requested review from
Qingfu-Liu,
dustinswales,
haiqinli,
tanyasmirnova and
barlage
as code owners
grantfirl
requested review from
mkavulich,
rhaesung and
climbfuji
and removed request for
andrewgettelman,
barlage,
joeolson42,
gthompsnWRF,
haiqinli,
tanyasmirnova,
SamuelTrahanNOAA,
RuiyuSun,
cenlinhe,
JongilHan66,
AnningCheng-NOAA,
lisa-bengtsson and
AndersJensen-NOAA
dustinswales
approved these changes
Oct 22, 2024
|
@climbfuji FYI, last one until we are caught up with ufs/dev. |
rhaesung
approved these changes
Oct 22, 2024
|
@matusmartini Can you take a look at the changes to |
Thank you @climbfuji Looks good. These changes should not interfere with NRL physics configuration as we use different mixing length formulation in |
Perfect, thanks! |
climbfuji
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identical to ufs-community#226