-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add linkcheck to CI #141
Add linkcheck to CI #141
Conversation
Meowdy! See your PR preview: |
Task linked: GA-1499 Add link checker to geocat-applications |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, might be worth updating the Contributor guide to mention some of the link details like using ref
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Unreasonably excited to have this 😆
This PR:
linkcheck.yml
as a separate action workflow file so that our entire CI won't show as failing if just linkcheck is having problems and potential linkcheck problems won't necessarily block PRs.:ref:
roles to internal links in cards inapplications/applications.rst
andindex.rst
references.bib
to remove redundant urls and correct a typo in a doilinkcheck_anchors = False
toconf.py
to allow linking to specific line numbers on github (invalid anchors will still go to the intended page, just not the intended location)linkcheck_ignore = [r'https://doi.org/10.1080/104732299303296']
toconf.py
. I tried to do some stuff with the user agent, but ultimately, this page is really interested in keeping track of the number of people who access it and I don't want to mess with their stats.Addresses GA-1499