Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link appearance #147

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Fix link appearance #147

merged 1 commit into from
Nov 7, 2024

Conversation

kafitzgerald
Copy link
Collaborator

PR Summary

This is a quick fix to address the problem where the links on these pages include the :ref: bit when they render.

I suspect the idea originally was to try something a little more robust so we didn't need to duplicate this code in two files to adjust filepaths for the links. This doesn't address that, but does make things work and look a little nicer for the time being.

Related Tickets & Documents

Closes #143

Copy link

github-actions bot commented Nov 7, 2024

Meowdy! See your PR preview:
🔍 Git commit SHA: 27d60fc
✅ Deployment Preview URL: https://NCAR.github.io/geocat-applications/_preview/147

@kafitzgerald kafitzgerald marked this pull request as ready for review November 7, 2024 00:53
Copy link
Member

@anissa111 anissa111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I was pretty certain that the :ref: roles were necessary, but clearly they're not. I wonder if this was something that popped up locally but not in the linkcheck action here.

In any case, thanks for the catch and fix!

@kafitzgerald kafitzgerald merged commit a9895f4 into NCAR:main Nov 7, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 7, 2024
@kafitzgerald kafitzgerald deleted the link_fix branch November 7, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links not rendering correctly on Python Applications
2 participants