Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upstream CI #577

Merged
merged 4 commits into from
Jan 3, 2024
Merged

Add upstream CI #577

merged 4 commits into from
Jan 3, 2024

Conversation

kafitzgerald
Copy link
Collaborator

@kafitzgerald kafitzgerald commented Dec 29, 2023

Adds upstream CI based upon what @anissa111 set up for geocat-comp and xarray's upstream CI. Includes geocat-viz and geocat-comp along with some key dependencies.

I was able to run this on my fork, but didn't realize turning off actions would break the link to prior runs. Let me know if you'd like me to turn it back on so you can check out some runs / logs.

I think this is probably a good start, but do wonder if it might catch "too much" the way it's currently configured (e.g. the frequency of testing and number of upstream dev packages we're testing).

We could also think about adding some sort of automation to generate issues when this fails. xarray and matplotlib both have this set up in slightly different ways. xarray's is a bit custom, but some other packages are using it as well (i.e. dask). matplotlib uses this issue-bot.

Closes #507 and #544.

@kafitzgerald kafitzgerald marked this pull request as ready for review December 29, 2023 19:02
@kafitzgerald kafitzgerald merged commit f48a523 into NCAR:main Jan 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add viz as upstream dependency
3 participants