Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily remove incorrect NCL_vector_5.py example #618

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

kafitzgerald
Copy link
Collaborator

Removes the (incorrect) NCL_vector_5.py example until we have a working curly vector implementation.

Closes #616
Relates to #314

If we'd rather not remove this for now, we could also look into using quiver from Matplotlib like some of the other vector examples, but I don't think that's a great option for this particular example. The vector field is rather complex and I think it'd be difficult to represent with that plot type. A streamplot is another option, but that's really a different type of visualization.

@kafitzgerald
Copy link
Collaborator Author

This is failing pre-commit because of PyCQA/docformatter#293

@jukent
Copy link
Collaborator

jukent commented Oct 14, 2024

I'm in favor of removing it, as you showed here. Or adding some sort of annotation that the example is not displaying scientifically significant vector lengths. I wonder if there are people using this example as a template for other visualization needs (pretty sure they're captured in a different example).

@kafitzgerald
Copy link
Collaborator Author

I'm in favor of removing it, as you showed here. Or adding some sort of annotation that the example is not displaying scientifically significant vector lengths. I wonder if there are people using this example as a template for other visualization needs (pretty sure they're captured in a different example).

Yeah, we have other streamplot examples already so I think the best thing to do here is remove it while we address the issue.

@kafitzgerald kafitzgerald merged commit 63ba2c6 into NCAR:main Oct 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NCL_vector_5.py currently misrepresents the data
2 participants