Updates to improve pkgdown website #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laijasmine
reviewed
Sep 3, 2020
There was a problem hiding this comment.
It is looking good! Just a couple of small comments :)
I'll have to look into why the Travis-CI build is failing. I don't think it is related to your changes. Seems like a mystery so far: omegahat/XML#16
_pkgdown.yml
Outdated
| contents: | ||
| - starts_with("add_") | ||
|
|
||
| - subtitle: DataOne functions |
There was a problem hiding this comment.
these function might be good candidates to be moved to the dataone R package
_pkgdown.yml
Outdated
| - 'get_orcid_email' | ||
|
|
||
| - subtitle: EML Functions | ||
| desc: Functions for creating and changing EML metadata |
There was a problem hiding this comment.
also probably good candidates to be moved to the EML package. eml_get_simple has been mentioned to be added : ropensci/EML#303 but I don't think we ever got around to doing that
… in the references tab so I deleted one. I also removed the overall title and switched subtitles to titles. Some examples use subtitle some just use title and description so maybe that was the problem.
…e intentionally not shown on the pkgdown. Tomorrow I will go through and make more notes on each to begin to determine which ought to be moved to datamgmt package and questions for Jeannette and Jasmine
Merge branch 'master' of https://github.com/NCEAS/arcticdatautils # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
|
merging these in, though Travis is still failing |
laijasmine
pushed a commit
that referenced
this pull request
Oct 2, 2020
Updates to improve pkgdown website
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I improved some of the function descriptions, added you (Jasmine Lai) as a contributor, changed the recommended installation method and attempted to make some changes to how the functions appear on the pkgdown site. I (think) that I added subheadings under the references tab to categorize the functions.