-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: add page organized by date #326
Conversation
This PR relate to #117
Hello @haesleinhuepf, it's me again! Could you take a moment to review this? I noticed something interesting: your original _toc.yml worked perfectly, but after my update, I had to adjust its position to make it work. Do you have any idea why that might be? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @SeverusYixin ! Just two minor questions. In general: try to change only things that are relevant for your work and leave the rest untouched
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @SeverusYixin ,
that looks already quite good. I just tested it by building the page and must note that the links do not look nice:
I think it would be better if the two links are on two lines and the [Link to content] stuff should dissapper. After modifying the code, consider trying it out and have a look at the page. All you need to execute locally are these lines.
Thanks!
Best,
Robert
Hi @haesleinhuepf, would you like to merge this PR first, and then create a new issue assigned to me for the Outlook styling improvements? |
I prefer fixing bugs in new pages before they become part of the public website. Thanks! |
Hi @SeverusYixin, I was just wondering why the lists on this page look different than the lists on other pages? Do you think it would be possible to reuse code building the pages also to avoid the bug discussed above? Thanks! |
Let me try it later and give you an answer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @haesleinhuepf ,
This is my PR, and I cannot be a reviewer to approve your changes. But I have checked it. Everything fine.
Thank you for your help!
This PR relate to #117 NFDI4BIOIMAGE/nfdi_search_engine#27
This PR closes #117 NFDI4BIOIMAGE/nfdi_search_engine#27