Skip to content

Commit

Permalink
NCRS-3363: changes from PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
alice-bell committed Dec 18, 2024
1 parent 978a3e9 commit 6153985
Show file tree
Hide file tree
Showing 25 changed files with 191 additions and 982 deletions.
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -111,4 +111,5 @@ lib/
yarn-error.log
storybook-static/
css/
.idea/
.idea/
.yarn/install-state.gz
4 changes: 4 additions & 0 deletions .storybook/_storybook.scss
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
@import '../src/styles/core.scss';
@import '../src/styles/variables.scss';
@import '../src/all.scss';

%demo-centered {
display: block;
margin: auto;
Expand Down
4 changes: 1 addition & 3 deletions .storybook/config.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import { configure, addParameters } from '@storybook/react';
import '../src/all.scss';
import './_storybook.scss';
import '../src/styles/core.scss';
import '../src/styles/variables.scss';


import NHSTheme from './theme';

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "nhsuk-react-components-extensions",
"version": "2.0.0-test.1",
"version": "2.0.0-beta.1",
"author": {
"email": "[email protected]",
"name": "Thomas Judd-Cooper",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@ import AccordionMenu from '..';
describe('AccordionMenu', () => {
it('matches snapshot', () => {
const component = render(<AccordionMenu />);
expect(component).toMatchSnapshot();
expect(component.container).toMatchSnapshot();
});

describe('Section', () => {
it('matches snapshot', () => {
const component = render(<AccordionMenu.Section heading="TestHeading" />);
expect(component).toMatchSnapshot();
expect(component.container).toMatchSnapshot();
});

it('passes through text', () => {
Expand Down Expand Up @@ -64,7 +64,7 @@ describe('AccordionMenu', () => {
describe('Link', () => {
it('matches snapshot', () => {
const component = render(<AccordionMenu.Link>Test</AccordionMenu.Link>);
expect(component).toMatchSnapshot();
expect(component.container).toMatchSnapshot();
expect(component.container.textContent).toBe('Test');
});
});
Expand Down
Loading

0 comments on commit 6153985

Please sign in to comment.