Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor the Care card component and make it a variant of the Card component #154

Closed
adam-the opened this issue Mar 25, 2023 · 2 comments · Fixed by #211
Closed

refactor the Care card component and make it a variant of the Card component #154

adam-the opened this issue Mar 25, 2023 · 2 comments · Fixed by #211
Labels
nhsuk-frontend-v8-upgrade Alignment to nhsuk-frontend v8

Comments

@adam-the
Copy link

see nhsuk/nhsuk-frontend#746

I'd like to work on this but I have one question first:
Should feature cards also be included in the card's type parameter? They seem to be mutually exclusive in the nunjucks template, so having all variants, excluding the clickable modifier, in the type parameter makes sense to me.

Doing it this way would seem to go against #68

@KaiSpencer
Copy link
Contributor

Hi @ItsiAdam,
Personally i agree with the type parameter implementation, although Its not something I've had a look at yet given me and @Tomdango currently focusing on v5 parity before any v6 changes which this falls under.

@jakeb-nhs jakeb-nhs added the nhsuk-frontend-v8-upgrade Alignment to nhsuk-frontend v8 label Apr 10, 2024
@jakeb-nhs
Copy link
Collaborator

This has now been addressed as part of the latest release: https://github.com/NHSDigital/nhsuk-react-components/releases/tag/v4.0.0
Care cards are no longer a standalone component and use the cardType prop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nhsuk-frontend-v8-upgrade Alignment to nhsuk-frontend v8
Projects
None yet
3 participants