Migrate nhsuk-frontend v8, bringing components into line with the current style guide. #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakeb-nhs
force-pushed
the
feature/nhsuk-frontend-v8
branch
9 times, most recently
from
34ad6b7
to
47e55bd
Compare
jakeb-nhs
force-pushed
the
feature/nhsuk-frontend-v8
branch
from
47e55bd
to
27495a0
Compare
…rent style guide.
jakeb-nhs
force-pushed
the
feature/nhsuk-frontend-v8
branch
from
27495a0
to
e392676
Compare
|
JoshuaBates-NHS
approved these changes
May 15, 2024
There was a problem hiding this comment.
Changes have been individually reviewed and checked against a consuming application - happy for this to go in as is. Duplication could be helped further along but it looks to be mainly around bootstrapping code which should not impact the overall quality of this change
This was
linked to
issues
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the changes required to migrate to nhsuk-frontend v8:
For a full list of changes in this release please refer to the migration doc.