-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snapshot testing via Storybook #188
Open
KaiSpencer
wants to merge
8
commits into
main
Choose a base branch
from
poc/storybook-for-snapshot-and-visual-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tomdango
reviewed
Jan 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks super overall - just a couple of comments 👍
…or now, pending chromatic integration.
…t the id and/or name to stop autoID generation.
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
KaiSpencer
changed the title
POC: Snapshot testing via Storybook
Snapshot testing via Storybook
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storybook has a new test runner built in, that comprises of Jest and Playwright, allowing a variety of testing techniques such as: visual tests, snapshot tests, a11y tests - Docs
This is a proof of concept to see how we could use the built in storybook testing to automatically have snapshot tests without having to define a test case per component. See config in
.storybook/test-runner.ts
This also experiments with the visual image testing, where a similar
screenshot
is taken (rendered under the hood with playwright and jest)