Refactor Company Application Status #349
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://nijobs-backend-pr-349.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cnotltqcn0vc73d8h7bg. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #349 +/- ##
===========================================
+ Coverage 90.34% 90.35% +0.01%
===========================================
Files 54 54
Lines 1470 1473 +3
Branches 246 245 -1
===========================================
+ Hits 1328 1331 +3
Misses 137 137
Partials 5 5 ☔ View full report in Codecov by Sentry. |
…h Application Status Enum - Tested "migration" of database (using the default value for ApplicationStatus) - Replaced the virtual ApplicationStatus field tests
Minipoloalex
force-pushed
the
312-refactor-offer-state
branch
from
29f88c7
to
fcd1f9a
Compare
jose-carlos-sousa
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the virtual state in company application with an enum.
Previously, the virtual state depended on whether the
rejectedAtandapprovedAtfields were defined. Now it is defined with an explicit enum instead of being a virtual field.I also had to define a default function for the application state enum depending on those same fields. With a simple default
PENDING, migrating the database would cause approved/rejected applications to be seen as pending. This function makes the default value depend onapprovedAtandrejectedAt.Also replaced the tests related with the virtual state.
Closes #312