-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate company application page #309
base: develop
Are you sure you want to change the base?
Conversation
Co-authored-by: Daniel Ferreira <[email protected]>
Co-authored-by: Daniel Ferreira <[email protected]>
ImportantThe workflow regarding this issue has been changed |
Co-authored-by: Daniel Ferreira <[email protected]>
42cab26
to
aa0ac75
Compare
@FranciscoCardoso913 @dsantosferreira any progress on this? |
…any is yet to be approved Co-authored-by: Daniel Ferreira <[email protected]>
…any is yet to be approved Co-authored-by: Daniel Ferreira <[email protected]>
…e' into validate-company-application-Page
The icon on the images I sent is the default one used by the alert component from material UI when the severity attribute is set to "warning". It is probably the "WarningAmber" icon, as you referred. |
Honestly, I prefer the filed version of the icon. |
I do think the filled version looks more like the remaining icons we use (from what I recall, but feel free to check it out) |
…nge warning icon to its filled version Co-authored-by: Francisco Cardoso <[email protected]>
Co-authored-by: Daniel Ferreira <[email protected]>
Co-authored-by: Daniel Ferreira <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the console.log
statements
…in unverified applications
Co-authored-by: Daniel Ferreira <[email protected]>
Co-authored-by: Daniel Ferreira <[email protected]>
…and the create offer form
16e11d1
to
3337414
Compare
3337414
to
3c5b58f
Compare
…cation services Making tests for the validate application and the fetch company application services
055fe5a
to
0274047
Compare
…ffer page with admin account
0274047
to
decd155
Compare
5f0cc3d
to
23032fa
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #309 +/- ##
===========================================
+ Coverage 89.19% 89.71% +0.52%
===========================================
Files 177 180 +3
Lines 3434 3530 +96
Branches 866 890 +24
===========================================
+ Hits 3063 3167 +104
+ Misses 371 363 -8
☔ View full report in Codecov by Sentry. |
Important:
This is a backend issue! See the original issue and the changes made in the backend here: NIAEFEUP/nijobs-be#306
Discussed solution:
Front-End changes:
States of the new page:
What is yet to be done:
Doubts: