Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack 5 support. Fix deprecated hook call #9

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Webpack 5 support. Fix deprecated hook call #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c1f521f
Fix deprecated hook call
Oct 14, 2020
e4358f8
Added stage property to plugin descriptor
Oct 14, 2020
443ba0e
Fix
Oct 14, 2020
16e7565
Added webpack version check
Oct 14, 2020
3f7bbf6
Fix version condition
Oct 14, 2020
e9d6b93
Update src/index.js
Mar 16, 2021
5dcf1b8
Update src/index.js
Mar 16, 2021
72d715f
Update src/index.js
Mar 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@
"lodash": "^4.17.5",
"webpack-sources": "^1.1.0"
},
"peerDependencies": {
"webpack": "^3.0.0 || ^4.4.0 || ^5.0.0"
},
"main": "src/index.js",
"homepage": "http://github.com/NMFR/last-call-webpack-plugin",
"repository": {
Expand Down
12 changes: 10 additions & 2 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ const isRegExp = require('lodash/isRegExp');
const keys = require('lodash/keys');
const values = require('lodash/values');
const webpackSources = require('webpack-sources');
const webpackVersion = require('webpack').version;

const isWebpackGreaterThan5 = webpackVersion[0] >= 5;
const PHASES = {
OPTIMIZE_CHUNK_ASSETS: 'compilation.optimize-chunk-assets',
OPTIMIZE_ASSETS: 'compilation.optimize-assets',
Expand Down Expand Up @@ -62,7 +64,13 @@ class LastCallWebpackPlugin {
}

buildPluginDescriptor() {
return { name: 'LastCallWebpackPlugin' };
const pluginDescriptor = { name: 'LastCallWebpackPlugin' };

if (isWebpackGreaterThan5) {
pluginDescriptor.stage = compilation.PROCESS_ASSETS_STAGE_OPTIMIZE
}

return pluginDescriptor;
}

resetInternalState() {
Expand Down Expand Up @@ -172,7 +180,7 @@ class LastCallWebpackPlugin {
(compilation, params) => {
this.resetInternalState();

if (hasOptimizeChunkAssetsProcessors) {
if (hasOptimizeChunkAssetsProcessors && !isWebpackGreaterThan5) {
compilation.hooks.optimizeChunkAssets.tapPromise(
this.pluginDescriptor,
chunks => this.process(compilation, PHASES.OPTIMIZE_CHUNK_ASSETS, { chunks: chunks })
Expand Down