Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Submodules in HDASApp #25

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Conversation

JingCheng-NOAA
Copy link
Collaborator

As stated in issue #23 , this PR is created to update the submodules in HDASApp.
Besides that, the corresponding Cmake files as well as module files are also updated.
The yaml files inside hafs-test are updated as well to reflect the updates in fv3-jedi and UFO variable name changes.

Made adjustment to hafs-test yaml file to replace `specific_humidity` with `water_vapor_mixing_ratio_wrt_moist_air`, and remove `tsea` from state variables.
@delippi
Copy link

delippi commented Nov 21, 2024

@JingCheng-NOAA, we just synced the submodules in RDASApp again this week with some changes that were useful for surface winds, an issue with a renamed variable, and fixes for online domain checks (via use of qcflag and missing value checks). I think it will be relevant for HDAS.

Here is the latest submodule update PR in RDASApp: NOAA-EMC/RDASApp#227
Here are some useful instructions that we use (if you don't already have them): https://github.com/NOAA-EMC/RDASApp/wiki/Sync-RDASApp-submodule-with-upstream-repositories

I don't readily see what hashes you've updated to here, but it would be good to have at least the following hashed submodules (along with any dependencies):

* sorc/fv3-jedi 136dfb9c
* sorc/ufo 0876a4ba

You don't need to close or add that update in this PR. But you should consider doing another update soon to grab those fixes.

@JingCheng-NOAA
Copy link
Collaborator Author

@JingCheng-NOAA, we just synced the submodules in RDASApp again this week with some changes that were useful for surface winds, an issue with a renamed variable, and fixes for online domain checks (via use of qcflag and missing value checks). I think it will be relevant for HDAS.

Here is the latest submodule update PR in RDASApp: NOAA-EMC/RDASApp#227 Here are some useful instructions that we use (if you don't already have them): https://github.com/NOAA-EMC/RDASApp/wiki/Sync-RDASApp-submodule-with-upstream-repositories

I don't readily see what hashes you've updated to here, but it would be good to have at least the following hashed submodules (along with any dependencies):

* sorc/fv3-jedi 136dfb9c
* sorc/ufo 0876a4ba

You don't need to close or add that update in this PR. But you should consider doing another update soon to grab those fixes.
@delippi Thank you so much for the RRFS instructions on submodule uddate, it's a very clear way to list out the changes.
What I did for this PR listed update is cd into each submodule directory and make sure to get in the latest udpate from either their dev branch or master branch in some case. And I do noticed that there is a submodule being removed by replacing with an env module file update as well. That's why I decided to update the module file in HDASApp as well. But I think next time I will follow the instructions to make corresponding updates.

@JingCheng-NOAA
Copy link
Collaborator Author

JingCheng-NOAA commented Dec 10, 2024

Continued the updates, including:

  1. remove submodule fms from .gitmodules, as fms will be loaded through modulefile.
  2. crtm: bb7adbf..78b96be
  3. fv3-jedi: 136dfb9..8ab22d5
  4. ioda: 71ee037..6f01481
  5. iodaconv: 6f87a0f..a2c29b8
  6. jedimake: 40d521f..36fc99b
  7. oops: 1ba321f..c8b0f61
  8. saber: de5015c..55f3258
  9. ufo: 5e5470f..5b22f34
  10. vader: 14e8bce..0792f69

@JingCheng-NOAA JingCheng-NOAA merged commit 74f5c80 into develop Dec 20, 2024
@JingCheng-NOAA JingCheng-NOAA deleted the feature/submoduleUpdate branch December 20, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants