Add unit testing #752
Closed
Add unit testing #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create separate developer.yml CI workflow
DusanJovic-NOAA
approved these changes
Feb 16, 2024
|
@junwang-noaa please review. I suggest squash & merge. |
junwang-noaa
approved these changes
Feb 18, 2024
|
@DusanJovic-NOAA Do we have an fv3 PR that will be committed in the upcoming ufs wm commites? Can we coordinate it with this one (ask the person to merge fv3atm when this PR is committed)? Thanks |
|
I see #767 scheduled for merge in the ufs-weather-model commit queue. @grantfirl can you please merge this branch with your #767 PR. This PR updates github workflow to run unit tests. |
Closed
|
@DusanJovic-NOAA I've merged in the current develop branch so it includes your changes. Otherwise everything should basically be as it was before. |
2 tasks
|
Pulled into #798 |
DusanJovic-NOAA
pushed a commit
that referenced
this pull request
Aug 8, 2024
…ow also includes #752) (#798) * Convert GFS_grid DDT: use contiguous arrays instead of blocked data structures * Add GCC-based CI build --------- Co-authored-by: Alex Richert <[email protected]> Co-authored-by: Dustin Swales <[email protected]>
|
Merged via #798 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
I relocated the build/ directory in the CI to be under the fv3atm repo directory because it made the gcovr setup simpler. I've also added some logic that ensures that the gcovr report and doxygen output only get generated for one of the jobs, but still under GCC.yml to keep things consolidated.
Issue(s) addressed
Addresses #729
Testing
Tested on personal computer. All CI jobs successful.
Dependencies
none