fix the documentation build for fv3atm, getting the CI to work #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardhartnett
changed the title
This was referenced Jan 9, 2025
edwardhartnett
requested review from
DusanJovic-NOAA and
AlexanderRichert-NOAA
DusanJovic-NOAA
approved these changes
Jan 9, 2025
AlexanderRichert-NOAA
approved these changes
Jan 10, 2025
|
Who is the other reviewer required to make this PR mergable? |
|
junwang-noaa
approved these changes
Jan 10, 2025
|
Probably we need to add @LarissaReames-NOAA to the list of those who can approve a PR here. @junwang-noaa can you please take a look at this PR and approve it? |
|
@edwardhartnett I approved it already, please see the comments above. After @LarissaReames-NOAA accept the invitation, I will add her to the list. Thanks
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR I change the CMake option ENABLE_DOCS to ENABLE_FV3ATM_DOCS, in order to avoid invoking the documentation build of UPP.
I also add a new CI workflow called "docs", and take the documentation build out of the GCC workflow. This will be more useful to programmers because having the "docs" CI run fail is pretty obvious.
There are no code changes in this PR; this is documentation and CI only.
Issue(s) addressed
Fixes #904
Testing
CI testing. No code changes in this PR.
Dependencies
N/A
Requirements before merging