-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the dependency on CPAN module List::MoreUtils #337
Draft
underwoo
wants to merge
55
commits into
NOAA-GFDL:main
Choose a base branch
from
underwoo:remove.perl.list.moreutils
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file generated to regrid is probably not correct, as the final output looks odd My guess is that is more on the file, and not on fregrid.
Made changes to other tests to allow a single file to be used in multiple tests.
The test was removed from the Makefile already
Remove unneeded test files, and all files in the old t directory Updated the CONTRIBUTING.md to remove the mention of bats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Perl script
split_ncvars.pl
uses a CPAN module List::MoreUtils for a single functionuniq
. The use of this function can be removed using a better method to grab the intersection of two arrays:This assumes the values in
@array1
and@array2
are unique. Since the arrays insplit_ncvars.pl
hold dimensions, the lists should be unique.How Has This Been Tested?
The
split_ncvars.pl
tests are run, which indicates the output is identical to previous runs.This PR should be taken after #331.
Checklist:
make distcheck
passes