Use FMS1 for MacOS builds #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
adcroft
commented
May 18, 2024
adcroft
commented
- MacOS builds have been failing recently
- This is apparently due to a recent break in gfortran 14.1 which is now incompatible with FMS2
- A proposed (@marshallward) workaround is to revert to FMS1 for the MacOS builds, which indeed appears to work
- This commit sets FRAMEWORK=fms1 and FMS_COMMIT=2019.01.03 only for the MacOS builds
- It leaves all other builds on FMS2
|
Let's send this to the dev-to-main branch rather than dev, so that we can continue to work on restoring FMS2 support. |
|
PS> The MacOS regression test fails because the target executable is still FMS2. Not sure why, but the MacOS stencil tests did pass |
adcroft
commented
May 18, 2024
- Given a recent incompatibility with FMS2 and gfortan 14.1 we need to revert to FMS1 for the MacOS builds.
|
Force pushed a fix . Had "fms" instead of "fms1" in the MacOS regression build |
|
I assume we want #641 to stay open so we don't forget to undo this work around when FMS2 or gfortran/MacOS is fixed? |
|
Yes let's take this one in and leave the issue up to handle in dev/gfdl. |
marshallward
merged commit 7d322d2
into
NOAA-GFDL:gfdl-to-main-2024-05-16
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.