Fix bug in radiation OBC update #645
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 20, 2024 15:40
Add an option to use the correct velocity (u_av) in the radation OBC calculation in RK2.
There was a problem hiding this comment.
These changes seem like they are moving in the right direction. There are two changes to this commit that I would suggest:
- Remove the comment on lines 1022-1023 of the new code, as this change addresses the point made by that comment.
- Add a
do_not_log=.not.associated(OBC)flag to the newget_param()call forUSE_OBC_U_INST_BUGso that it does not appear in the MOM_parameter_doc files for cases where it is not relevant.
Hallberg-NOAA
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the update to the radiation OBC's is called the time-averaged velocity should be used, not the instantaneous velocity. This was fixed in the RK2B algorithm but not in RK2A in part because of how the update to the OBC's is between a non-blocking update.
The original sequence has been preserved, but an additional call to update the radiation OBC's has been added after the blocking update which should only be do if OBC's are used and the bug flag is set to false.
This PR will not change answers for simulations without OBC's and will only change answers for cases with OBC's when
USE_OBC_U_INST_BUG = True.