New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[F32] NH_P_Grad #38

Merged

FlorianDeconinck merged 2 commits into NOAA-GFDL:develop from FlorianDeconinck:fix/F32/nh_p_grad

Dec 20, 2024

Collaborator

FlorianDeconinck commented Dec 19, 2024

Minor PR to fix floating point precision consistency on NonHydrostaticPressureGradient
Added a non-optional use_logp flag and associated test


          Fix for floating point precision kept through np.power

892f38e

Pass use_logp and check for it

FlorianDeconinck requested review from fmalatino, bensonr and oelbert

December 19, 2024 16:48


          Pass use_logp from DynCore downstream

a0bb6b9

oelbert approved these changes

View reviewed changes

Collaborator

oelbert left a comment

👍

fmalatino approved these changes

View reviewed changes

FlorianDeconinck merged commit d9106db into NOAA-GFDL:develop

4 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet