-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separating sea ice melt/formation from liquid precipitation field #214
base: dev/gfdl
Are you sure you want to change the base?
Conversation
For unjustified legacy reasons, these have been bundled together in the past. They are not only bundled together in SIS2 variables, but also in the ice-ocean fluxes passed to the coupler and hence to MOM6. This commit attempts to address this Issue: NOAA-GFDL#213 However, I currently am getting a SEGFAULT error stating that `iobt%seaice_melt` has not been allocated memory when I try to do a checksum on it.
This is the line that is currently giving me problems when running: If I remove it, the model runs (I am using the |
@theresa-morrison pointed out that that I forgot to allocate the new After doing so in this PR, my Baltic sea test now works! |
This fixes a bug introduced in my previous two commits, in which I was unintentionally adding IOF%seaice_melt rate on top of the previous timesteps result, without realizing that it never gets set back to zero!
Is there any reason we would want to be able to save the old method for calculating net_melt = melt+ lprec? Or is prlq (new) + fsitherm = prlq (old) sufficient for recreating old results if needed? |
I personally think this would be undesirable, as it just propagates something that was already mislabelled and could lead to further misinterpretation. |
We always retain the ability to use the old calculations if there is any chance at all that anyone is using them, no matter how ugly the code was. We can wrap in a runtime BUG flag or an ANSWER_DATE flag, but we do not ever change other people's answers without warning and explicit consent. Keeping the new method as the only option is only sufficient if it can be configured to be bitwise identical to the old one! |
Thanks for clarifying @Hallberg-NOAA. I do think answers will not change in the sense that the sum of the two existing diagnostics, Is this fine or should I add a runtime BUG flag? I assume I can follow the implementation for something like this: Lines 214 to 223 in 2c49005
|
For unjustified legacy reasons, these have been bundled together in the past. They are not only bundled together in SIS2 variables, but also in the ice-ocean fluxes passed to the coupler and hence to MOM6.
This commit attempts to address this Issue: #213
However, I currently am getting a SEGFAULT error stating that
iobt%seaice_melt
has not been allocated memory when I try to do a checksum on it.(Edit: See compaion PRs NOAA-GFDL/MOM6#710 and NOAA-GFDL/FMScoupler#145)