Skip to content

Commit

Permalink
Merge pull request #140 from NOAA-GFDL/128.and_other_small_things
Browse files Browse the repository at this point in the history
intakebuilder --> catalogbuilder edits
  • Loading branch information
ceblanton authored Jul 30, 2024
2 parents 1465431 + ef3082c commit 8e085a1
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 30 deletions.
2 changes: 1 addition & 1 deletion environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ dependencies:
- pyyaml
- pylint
- jsonschema
- noaa-gfdl::intakebuilder
- noaa-gfdl::catalogbuilder
- conda-forge::cylc-flow>=8.2.0
- conda-forge::cylc-rose
- conda-forge::metomi-rose
Expand Down
32 changes: 4 additions & 28 deletions fre/catalog/frecatalog.py
Original file line number Diff line number Diff line change
@@ -1,37 +1,13 @@
import click
from scripts import gen_intake_gfdl
from scripts import test_catalog
import catalogbuilder
from catalogbuilder.scripts import gen_intake_gfdl
from catalogbuilder.scripts import test_catalog

@click.group(help=click.style(" - access fre catalog subcommands", fg=(64,94,213)))
def catalogCli():
''' entry point for click into fre catalog cli calls '''
pass

#@catalogCli.command()
#@click.option('-i',
# '--input_path',
# required = True,
# nargs = 1)
#@click.option('-o',
# '--output_path',
# required = True,
# nargs = 1)
#@click.option('--filter_realm',
# nargs = 1)
#@click.option('--filter_freq',
# nargs = 1)
#@click.option('--filter_chunk',
# nargs = 1)
#@click.option('--overwrite',
# is_flag = True,
# default = False)
#@click.option('--append',
# is_flag = True,
# default = False)
#@click.pass_context
#def build(context, input_path, output_path, filter_realm, filter_freq, filter_chunk,
# overwrite,append):
# """ - Execute fre catalog build """
# context.forward(build_script)

@catalogCli.command()
#TODO arguments dont have help message. So consider changing arguments to options?
Expand Down
5 changes: 5 additions & 0 deletions fre/catalog/tests/test_fre_catalog.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
#!/usr/bin/env python3

def test_fre_catalog_import():
from fre import catalog
assert catalog is not None
3 changes: 2 additions & 1 deletion meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ requirements:
- pyyaml
- pylint
- jsonschema
- noaa-gfdl::intakebuilder
- noaa-gfdl::catalogbuilder
- conda-forge::cylc-flow>=8.2.0
- conda-forge::cylc-rose
- conda-forge::metomi-rose
Expand All @@ -58,6 +58,7 @@ test:
- fre.make
- fre.app
- fre.cmor
- fre.catalog
commands:
- pytest --config-file=fre/pytest.ini --cov-config=fre/coveragerc --cov=fre fre/
- pylint fre/ || echo "pylint returned non-zero exit code and will kill the workflow. guarding against this now."
Expand Down
1 change: 1 addition & 0 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
'pyyaml',
'pylint',
'pytest',
'catalogbuilder',
'jsonschema',
'cylc-flow',
'cylc-rose',
Expand Down

0 comments on commit 8e085a1

Please sign in to comment.