Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

To fix a failing test #3

Merged
merged 2 commits into from
Sep 6, 2024
Merged

To fix a failing test #3

merged 2 commits into from
Sep 6, 2024

Conversation

Geary-Layne
Copy link
Contributor

Linear Issue

IDSSE-906

Changes

  • I don't think this change has anything to do with task 906, but it was needed to have DAS test to pass
    • I believe a change to translate_client_request.py nessesited this change
    • There was just a shifting of request argument, with slice being moved into base data request

Explanation

N/A

@Geary-Layne Geary-Layne self-assigned this Sep 6, 2024
@Geary-Layne Geary-Layne merged commit 631f717 into main Sep 6, 2024
1 check passed
@Geary-Layne Geary-Layne deleted the chore/idsse-906/thread-safe-ack-nack branch September 6, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Geary-Layne Geary-Layne

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Geary-Layne