[refactor] 7주차 코드리뷰 반영 -> loading 관리 (#21)

NOW-SOPT-ANDROID · Jul 1, 2024 · 1638b2c · 1638b2c
1 parent aae57df
commit 1638b2c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 17 deletions.
diff --git a/app/src/main/java/com/sopt/now/compose/ui/home/HomeViewModel.kt b/app/src/main/java/com/sopt/now/compose/ui/home/HomeViewModel.kt
@@ -24,12 +24,10 @@ class HomeViewModel @Inject constructor(
     val followerState = _followerState.asStateFlow()
 
     private var _eventNetworkError = MutableLiveData(false)
-    val eventNetworkError: LiveData<Boolean>
-        get() = _eventNetworkError
 
     private var _isNetworkErrorShown = MutableLiveData(false)
 
-    val friendList = mutableListOf<Profile>()
+    private val friendList = mutableListOf<Profile>()
 
     init {
         fetchFollowerList()

diff --git a/app/src/main/java/com/sopt/now/compose/ui/signUp/SignUpScreen.kt b/app/src/main/java/com/sopt/now/compose/ui/signUp/SignUpScreen.kt
@@ -29,7 +29,6 @@ import androidx.compose.ui.unit.sp
 import androidx.lifecycle.viewmodel.compose.viewModel
 import androidx.navigation.NavHostController
 import com.sopt.now.compose.R
-import com.sopt.now.compose.data.model.RequestSignUpDto
 import com.sopt.now.compose.ui.base.SoptInputTextField
 import com.sopt.now.compose.ui.base.SoptOutlinedButton
 import com.sopt.now.compose.ui.base.SoptPasswordTextField
@@ -60,7 +59,7 @@ fun SignUpScreen(
             }
 
             is SignUpSideEffect.Loading -> {
-                Toast.makeText(context, event.message, Toast.LENGTH_SHORT).show()
+
             }
 
             is SignUpSideEffect.Error -> {
@@ -87,16 +86,6 @@ fun SignUpScreen(
             }
         }
 
-        val isSignUpButtonEnabled by remember(id, password, nickname, phoneNumber) {
-            mutableStateOf(
-                id.length in MIN_LENGTH_LOGIN..MAX_LENGTH_LOGIN
-                        && password.length in MIN_LENGTH_PASSWORD..MAX_LENGTH_PASSWORD
-                        && nickname.isNotEmpty() && !nickname.contains(
-                    " "
-                ) && phoneNumber.matches(Regex("^010-\\d{4}-\\d{4}\$"))
-            )
-        }
-
         Text(
             text = stringResource(id = R.string.sign_up_title),
             fontWeight = FontWeight.Bold,

diff --git a/app/src/main/java/com/sopt/now/compose/ui/signUp/SignUpSideEffect.kt b/app/src/main/java/com/sopt/now/compose/ui/signUp/SignUpSideEffect.kt
@@ -2,6 +2,6 @@ package com.sopt.now.compose.ui.signUp
 
 sealed class SignUpSideEffect {
     data class Success(val message: String) : SignUpSideEffect()
-    data class Loading(val message: String) : SignUpSideEffect()
+    object Loading : SignUpSideEffect()
     data class Error(val message: String) : SignUpSideEffect()
-}
+}