Feat/#5 week2 xml 필수과제 구현 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyeeum
requested review from
chattymin,
twogarlic,
kez-lab,
boiledEgg-s and
a team
hyeeum
requested review from
youjin09222
and removed request for
twogarlic and
a team
chattymin
requested changes
Apr 20, 2024
Comment on lines
32
to
35
| (holder as UserViewHolder).ivProfile.setImageResource(item.profileImage) | ||
| holder.tvName.text = item.name | ||
| holder.tvSelfDescription.text = item.selfDescription | ||
| holder.setIsRecyclable(false) |
There was a problem hiding this comment.
homeListList.getOrNull(position) = 해당 index에 값이 없으면 exception을 던지는 것이 아닌 null을 반환하기 때문에 조금 더 안전한 개발이 가능합니다
Comment on lines
9
to
11
| val ivProfile: ImageView = view.findViewById(R.id.iv_profile) | ||
| val tvName: TextView = view.findViewById(R.id.tv_name) | ||
| val tvSelfDescription: TextView = view.findViewById(R.id.tv_self_description) |
There was a problem hiding this comment.
헉.
findViewById는 사용 금지!!!!!!!!!!!!!!!!!!
다른 방법을 찾아봅시다!!!!!!!!!
There was a problem hiding this comment.
바인딩 객체를 인자로 받아 구현하는 편이 좋겠네요~
Comment on lines
50
to
52
| val intent = Intent(this, MainActivity::class.java) | ||
| saveUserInfo(id,pw,nick) | ||
| startActivity(intent) |
Comment on lines
+55
to
+63
| private fun saveUserInfo(id:String,pw:String,nick:String) { | ||
| val sharedPreferences = getSharedPreferences("userInfo", MODE_PRIVATE) | ||
| val editor = sharedPreferences.edit() | ||
| editor | ||
| .putString("userId", id) | ||
| .putString("userPw", pw) | ||
| .putString("userNick", nick) | ||
| .apply() | ||
| } |
There was a problem hiding this comment.
헉 sharedPreference 너무 좋아요!!
그런데 데이터를 가져오는 과정은 View보다는 ViewModel에 적합한 코드 같네요!! 수정해볼까용~
Comment on lines
+57
to
+62
| companion object { | ||
| const val MIN_ID_LENGTH = 6 | ||
| const val MAX_ID_LENGTH = 10 | ||
| const val MIN_PW_LENGTH = 8 | ||
| const val MAX_PW_LENGTH = 12 | ||
| } |
boiledEgg-s
approved these changes
Apr 21, 2024
Comment on lines
9
to
11
| val ivProfile: ImageView = view.findViewById(R.id.iv_profile) | ||
| val tvName: TextView = view.findViewById(R.id.tv_name) | ||
| val tvSelfDescription: TextView = view.findViewById(R.id.tv_self_description) |
There was a problem hiding this comment.
바인딩 객체를 인자로 받아 구현하는 편이 좋겠네요~
youjin09222
reviewed
Apr 21, 2024
| adapter = homeListAdapter | ||
| layoutManager = LinearLayoutManager(requireContext()) | ||
| } | ||
| homeListAdapter.setHomeList(HomeListData.homeListData) |
There was a problem hiding this comment.
리스트 데이터를 따로 저장해서 사용하니까 코드가 확실히 간단해지네요!!
youjin09222
reviewed
Apr 21, 2024
Comment on lines
+24
to
+29
| private fun getUserInfo() { | ||
| val userInfo = activity?.getSharedPreferences("userInfo", Context.MODE_PRIVATE) | ||
| binding.tvMainNick.text = userInfo?.getString("userNick", "") | ||
| binding.tvMainId.text = userInfo?.getString("userId", "") | ||
| binding.tvMainPw.text = userInfo?.getString("userPw", "") | ||
| } |
There was a problem hiding this comment.
SharedPreferences를 사용하여 코드가 간단하고 직관적이네요!
kez-lab
reviewed
Apr 26, 2024
Comment on lines
32
to
35
| (holder as UserViewHolder).ivProfile.setImageResource(item.profileImage) | ||
| holder.tvName.text = item.name | ||
| holder.tvSelfDescription.text = item.selfDescription | ||
| holder.setIsRecyclable(false) |
There was a problem hiding this comment.
homeListList.getOrNull(position) = 해당 index에 값이 없으면 exception을 던지는 것이 아닌 null을 반환하기 때문에 조금 더 안전한 개발이 가능합니다
Comment on lines
8
to
10
| selfDescription = "멀티 뷰 리싸이클러뷰!", | ||
| 0 | ||
| ), |
There was a problem hiding this comment.
HomeList.VIEW_TYPE_USER 상수를 만들었으니 상수를 활용하는 것이 좋아보여요!
…ID/hyeumm-song into feat/#5-week2_xml
chattymin
approved these changes
May 1, 2024
Comment on lines
+50
to
+52
| val intent = Intent(this, MainActivity::class.java).apply { | ||
| saveUserInfo(id, pw, nick) | ||
| } |
Comment on lines
+9
to
+13
| binding.run { | ||
| ivProfile.setImageResource(friendData.profileImage) | ||
| tvName.text = friendData.name | ||
| tvSelfDescription.text = friendData.selfDescription | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌𝘐𝘴𝘴𝘶𝘦𝘴
📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯
📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵
KakaoTalk_20240419_013037282.mp4
💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴
이번 주차 과제에 뷰모델을 적용해보려고 했는데..다른 자잘자잘한 부분에 집중하다보니 미처 시도하지 못했습니다..
시험이 끝나면 무조건 뷰모델부터 구현할게요!!
항상 부족한 코드가 많지만 리뷰달아주시면 최선을 다해서 반영해보겠습니닷..!!
코리 반영하기