Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/week compose 06 #12

Open
wants to merge 12 commits into
base: develop-compose
Choose a base branch
from
Open

Feat/week compose 06 #12

wants to merge 12 commits into from

Conversation

hyoeunjoo
Copy link
Collaborator

πŸ“Œπ˜π˜΄π˜΄π˜Άπ˜¦π˜΄

  • closed #

πŸ“Žπ˜žπ˜°π˜³π˜¬ π˜‹π˜¦π˜΄π˜€π˜³π˜ͺ𝘱𝘡π˜ͺ𝘰𝘯

  • Login ViewModel 뢄리
  • SignUp ViewModel 뢄리

πŸ“·π˜šπ˜€π˜³π˜¦π˜¦π˜―π˜΄π˜©π˜°π˜΅

week06.compose.mp4

πŸ’¬π˜›π˜° π˜™π˜¦π˜·π˜ͺ𝘦𝘸𝘦𝘳𝘴

@hyoeunjoo hyoeunjoo requested review from chanubc, OliviaYJH, cacaocoffee and kez-lab and removed request for chanubc and OliviaYJH May 24, 2024 14:02
@hyoeunjoo hyoeunjoo self-assigned this May 24, 2024
OliviaYJH
OliviaYJH approved these changes May 26, 2024
View reviewed changes
app/src/main/java/com/sopt/now/compose/LoginViewModel.kt Outdated
Comment on lines 18 to 19
var loginId = mutableStateOf("")
var loginPw = mutableStateOf("")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recomposition을 μœ„ν•΄ μ΄λ ‡κ²Œ λ°”κΎΈλŠ”κ±΄ μ–΄λ–¨κΉŒμš”?

Suggested change
var loginId = mutableStateOf("")
var loginPw = mutableStateOf("")
var loginId by remember { mutableStateOf("") }
var loginPw by remember { mutableStateOf("") }

app/src/main/java/com/sopt/now/compose/LoginViewModel.kt Outdated
Comment on lines 39 to 43
Toast.makeText(
context,
"둜그인 성곡",
Toast.LENGTH_SHORT,
).show()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λ·°λͺ¨λΈμ˜ 역할에 맞게 ν† μŠ€νŠΈ λ©”μ„Έμ§€λŠ” λ·°μ—μ„œ λ„μš°λ©΄ 쒋을 것 κ°™μ•„μš”!

cacaocoffee
cacaocoffee approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@cacaocoffee cacaocoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν•©μ„Έλ•Œλ¬Έμ— 바쁠텐데도 κ³Όμ œκΉŒμ§€ ν•˜λŠλΌ 수고 λ§ŽμœΌμ…¨μŠ΅λ‹ˆλ‹€! viewmodel 에 톡신 λ‘œμ§μ€ 6μ£Όμ°¨λ•Œ λ°°μ› λ˜ κ²ƒλ“€λ‘œ λ°”κΏ”λ³΄μ‹œκΈΈ μΆ”μ²œλ“œλ €μš”!

app/src/main/java/com/sopt/now/compose/SignUpViewModel.kt Outdated
Comment on lines 18 to 21
var signupId = mutableStateOf("")
var signupPw = mutableStateOf("")
var signupName = mutableStateOf("")
var signupPhone = mutableStateOf("")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 뢀뢄도 μœ„μ— μ •ν˜„λ‹˜μ΄ 말씀해 μ£Όμ‹ κ²ƒμ²˜λŸΌ λ³€κ²½ν•˜λ©΄ 쒋을거 κ°™μ•„μš”

chanubc
chanubc reviewed Jun 3, 2024
View reviewed changes
Copy link
Member

@chanubc chanubc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λ¦¬μ»΄ν¬μ§€μ…˜λ§Œ μ£Όμ˜ν•˜λ©΄ 쒋을것 κ°™μ•„μš”!

λ‚˜λ¨Έμ§€λŠ” xmlκ³Ό λ™μΌν•©λ‹ˆλ‹€!

app/src/main/AndroidManifest.xml
Comment on lines +17 to +20
<uses-library
android:name="org.apache.http.legacy"
android:required="false" />

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이건 μ–΄λ–€κ±°μ£ ??

app/src/main/java/com/sopt/now/compose/data/AuthRepoImpl.kt
request = RequestSignUpDto(
authenticationId = authEntity.id,
password = authEntity.pw,
nickname = authEntity.name ?: "",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
nickname = authEntity.name ?: "",
nickname = authEntity.name.orEmpty(),

μΏ„ν‹€λ¦°μ˜ ν™•μž₯ν•¨μˆ˜λ„ μ‚¬μš© κ°€λŠ₯ν•΄μš”!

app/src/main/java/com/sopt/now/compose/data/api/AuthService.kt
@GET("member/info")
fun getUserInfo(
@Header("memberId") memberId : Int
): Call<ResponseUserProfile>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ–˜λ„ Response둜 λ°”κΎΈμ–΄λ³΄μ•Όμš”

app/src/main/java/com/sopt/now/compose/presentation/Login/LoginActivity.kt
Comment on lines +90 to +91
value = viewModel.loginId.value,
onValueChange = { viewModel.loginId.value = it },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이러면 λ¦¬μ»΄ν¬μ§€μ…˜μ— 영ν–₯을 받을거 κ°™μ•„μš”! by λ₯Ό ν™œμš©ν•΄λ³΄μ•„μš” (저도 λ¦¬μ»΄ν¬μ§€μ…˜μ€ 아직..)γ… 

app/src/main/java/com/sopt/now/compose/presentation/SignUp/SignUpViewModel.kt
Comment on lines +21 to +24
var signUpId = mutableStateOf("")
var signUpPw = mutableStateOf("")
var signUpName = mutableStateOf("")
var signUpPhone = mutableStateOf("")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
var signUpId = mutableStateOf("")
var signUpPw = mutableStateOf("")
var signUpName = mutableStateOf("")
var signUpPhone = mutableStateOf("")
var signUpId by remember { mutableStateOf("") }
var signUpPw by remember { mutableStateOf("") }
var signUpName by remember { mutableStateOf("") }
var signUpPhone by remember { mutableStateOf("") }

μ΄λ ‡κ²Œ ν•΄μ•Ό λ¦¬μ»΄ν¬μ§€μ…˜ 영ν–₯을 받지 μ•Šμ„ 것 κ°™μ•„μš”!

rememberλŠ” μƒνƒœλ₯Ό μœ μ§€ν•˜μ—¬ λ¦¬μ»΄ν¬μ§€μ…˜μ΄ λ°œμƒν•˜λ”λΌλ„ μž…λ ₯된 값이 μ΄ˆκΈ°ν™”λ˜μ§€ μ•Šλ„λ‘ ν•΄μ€€λ‹€κ³  ν•˜λ„€μš”!
by rememberλ₯Ό 같이 μ‚¬μš©ν•˜λ©΄ μƒνƒœκ΄€λ¦¬μ— λ”μš± 효율적일 것 κ°™μ•„μš”!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOW-SOPT-ANDROID/chanwoo-bae#17 (comment)

var id by rememberSaveable { mutableStateOf("") }
var password by rememberSaveable { mutableStateOf("") }
var nickName by rememberSaveable { mutableStateOf("") }
var mbti by rememberSaveable { mutableStateOf("") }

rememberSaveable: μ»΄ν¬λ„ŒνŠΈμ˜ 생λͺ…μ£ΌκΈ° λ™μ•ˆ μƒνƒœλ₯Ό μœ μ§€ν•˜λ©°, ν”„λ‘œμ„ΈμŠ€ μ’…λ£Œ 및 ꡬ성 λ³€κ²½(예: ν™”λ©΄ νšŒμ „) μ‹œμ—λ„ μƒνƒœλ₯Ό μœ μ§€ν•©λ‹ˆλ‹€.

μ΄λŸ°κ²ƒλ„ μžˆλ‹€κ³  ν•©λ‹ˆλ‹€!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chanubc chanubc chanubc left review comments

@OliviaYJH OliviaYJH OliviaYJH approved these changes

@cacaocoffee cacaocoffee cacaocoffee approved these changes

@kez-lab kez-lab Awaiting requested review from kez-lab

Assignees

@hyoeunjoo hyoeunjoo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hyoeunjoo @cacaocoffee @OliviaYJH @chanubc