Skip to content

Commit

Permalink
[chore] Typo cooing -> cooling
Browse files Browse the repository at this point in the history
```bash
rg dataCoilCooingDX -l | xargs -I @ sed -i 's/dataCoilCooingDX/dataCoilCoolingDX/g' @
rg cooing -l | xargs -I @ sed -i 's/cooing/cooling/g' @
rg Cooing -l | xargs -I @ sed -i 's/Cooing/Cooling/g' @
```
  • Loading branch information
jmarrec committed Jan 23, 2025
1 parent 31e3c33 commit 701f4ba
Show file tree
Hide file tree
Showing 25 changed files with 132 additions and 131 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ \section{Introduction}\label{introduction-002}
\caption{Curve Fit Tool Input Interface \protect \label{fig:curve-fit-tool-input-interface}}
\end{figure}

The tool can be used for Coil:Cooing:DX:SingleSpeed, Coil:Heating:DX:SingleSpeed, Coil:Cooing:DX:TwoSpeed (high and low speed) , CoilPerformance:DX:Cooling (each stage), and any HVAC equipment that use Biquadratic, Cubic or Quadratic curves. To add this flexibility generic input data labels can be populated by selecting ``Other'' for DX Coil Type input field, located in Cell B3 in Figure~\ref{fig:curve-fit-tool-input-interface}.
The tool can be used for Coil:Cooling:DX:SingleSpeed, Coil:Heating:DX:SingleSpeed, Coil:Cooling:DX:TwoSpeed (high and low speed) , CoilPerformance:DX:Cooling (each stage), and any HVAC equipment that use Biquadratic, Cubic or Quadratic curves. To add this flexibility generic input data labels can be populated by selecting ``Other'' for DX Coil Type input field, located in Cell B3 in Figure~\ref{fig:curve-fit-tool-input-interface}.
Original file line number Diff line number Diff line change
Expand Up @@ -1252,7 +1252,7 @@ \subsubsection{SHR Calculation Using User Specified SHR Modifier Curves}\label{s
SHR = SH{R_{rated}} \cdot SHRFT\left( {{T_{wb,i}},{T_{db,i}}} \right) \cdot SHRFFF\left( {FF} \right)
\end{equation}

The cooing coil outlet air enthalpy is given by:
The cooling coil outlet air enthalpy is given by:

\begin{equation}
{h_{out}} = {h_{in}} - \frac{{{{\dot Q}_{total}}}}{{\dot m}}
Expand Down Expand Up @@ -1448,7 +1448,7 @@ \subsubsection{Latent Capacity Degradation}\label{latent-capacity-degradation}

\(T_{db,rated}\) is the dry-bulb temperature of air entering the cooling coil at rated conditions (26.7\(^{\circ}\)C)

\(T_{wb,rated}\) is the wet-bulb temperature of air entering the cooing coil at rated conditions (19.4\(^{\circ}\)C).
\(T_{wb,rated}\) is the wet-bulb temperature of air entering the cooling coil at rated conditions (19.4\(^{\circ}\)C).

The cooling coil on and off times are then calculated based on the maximum number of cycles per hour and the calculated run-time fraction for the coil.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1065,7 +1065,7 @@ \subsubsection{Model Description}\label{model-description-2}

If Heating Priority is specified and the total heating requirement in all zones is not equal to zero, then heating is selected as the operating mode. If the total heating requirement is equal to zero and the total cooling requirement is not equal to zero, then cooling is selected as the operating mode. If the total cooling requirement and total heating requirement are equal to zero then the zones are allowed to float (no heating or cooling provided).

If Zone Priority is specified and the total number of zones requiring cooling is greater than the total number of zones requiring heating, then cooling is selected as the operating mode. If the total number of zones requiring heating is greater than the total number of zones requiring cooling, then heating is selected as the operating mode. If the total number of zones requiring cooling is equal to the total number of zones requiring heating, then the magnitude of the total cooling and heating requirements for all zones sets the operating mode. In this case, if the magnitudes of the cooling and heating requirements are zero, then the zones are allowed to float (no heating or cooing provided). If the magnitudes of the cooling and heating requirements are non-zero and identical, then cooling is selected as the operating mode.
If Zone Priority is specified and the total number of zones requiring cooling is greater than the total number of zones requiring heating, then cooling is selected as the operating mode. If the total number of zones requiring heating is greater than the total number of zones requiring cooling, then heating is selected as the operating mode. If the total number of zones requiring cooling is equal to the total number of zones requiring heating, then the magnitude of the total cooling and heating requirements for all zones sets the operating mode. In this case, if the magnitudes of the cooling and heating requirements are zero, then the zones are allowed to float (no heating or cooling provided). If the magnitudes of the cooling and heating requirements are non-zero and identical, then cooling is selected as the operating mode.

\paragraph{Calculation of Bypass Duct Mixer Node Conditions}\label{calculation-of-bypass-duct-mixer-node-conditions}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ \subsection{Overview}\label{overview-007}

\subsection{Model Description}\label{model-description-004}

The model first determines operating modes based on the cooling and heating loads on the system, and then decides which calculation algorithm is called. It calls the cooling calculation subroutine when cooling load is demanded, the heating calculation subroutine when heating load is demanded, and both cooling and heating calculation subroutines when both cooling and heating loads are demanded, i.e., simultaneous cooing-heating mode. It then calculates mass-weighed temperatures and heat transfer energy. Six different operating modes (0 through 5) are possible:
The model first determines operating modes based on the cooling and heating loads on the system, and then decides which calculation algorithm is called. It calls the cooling calculation subroutine when cooling load is demanded, the heating calculation subroutine when heating load is demanded, and both cooling and heating calculation subroutines when both cooling and heating loads are demanded, i.e., simultaneous cooling-heating mode. It then calculates mass-weighed temperatures and heat transfer energy. Six different operating modes (0 through 5) are possible:

0: off

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2968,7 +2968,7 @@ \subsubsection{Inputs}\label{inputs-8-027}
\paragraph{Field: Maximum Outlet Air Temperature During Heating Operation}\label{field-maximum-outlet-air-temperature-during-heating-operation}
This numeric field defines the maximum outlet air temperature leaving the system when the unit is operating to provide heating. Values are specified in degrees Celsius and must be greater than 0. The default value is 50°C. This value must be greater than or equal to the minimum outlet air temperature during cooing operation.
This numeric field defines the maximum outlet air temperature leaving the system when the unit is operating to provide heating. Values are specified in degrees Celsius and must be greater than 0. The default value is 50°C. This value must be greater than or equal to the minimum outlet air temperature during cooling operation.
\paragraph{Field: Dehumidification Control Type}\label{field-dehumidification-control-type-5-000}
Expand Down
6 changes: 3 additions & 3 deletions src/EnergyPlus/AirflowNetwork/src/Solver.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -10521,10 +10521,10 @@ namespace AirflowNetwork {
} else {
// Replace the convenience function with in-place code
std::string mycoil = DisSysCompCoilData(i).name;
auto it = std::find_if(m_state.dataCoilCooingDX->coilCoolingDXs.begin(),
m_state.dataCoilCooingDX->coilCoolingDXs.end(),
auto it = std::find_if(m_state.dataCoilCoolingDX->coilCoolingDXs.begin(),
m_state.dataCoilCoolingDX->coilCoolingDXs.end(),
[&mycoil](const CoilCoolingDX &coil) { return coil.name == mycoil; });
if (it != m_state.dataCoilCooingDX->coilCoolingDXs.end()) {
if (it != m_state.dataCoilCoolingDX->coilCoolingDXs.end()) {
// Set the airloop number on the CoilCoolingDX object, which is used to collect the runtime fraction
it->airLoopNum = DisSysCompCoilData(i).AirLoopNum;
} else {
Expand Down
2 changes: 1 addition & 1 deletion src/EnergyPlus/ChillerReformulatedEIR.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1678,7 +1678,7 @@ void ReformulatedEIRChillerSpecs::size(EnergyPlusData &state)

// Output warning message if negative values are found in the EIRFPLR curve output. Results in Fatal error.
if (FoundNegValue) {
ShowWarningError(state, "Energy input to cooing output ratio function of part-load ratio curve shows negative values ");
ShowWarningError(state, "Energy input to cooling output ratio function of part-load ratio curve shows negative values ");
ShowContinueError(state, format("for Chiller:Electric:ReformulatedEIR = {}.", equipName));
ShowContinueError(state,
"EIR as a function of PLR curve output at various part-load ratios and condenser water temperatures shown below:");
Expand Down
36 changes: 18 additions & 18 deletions src/EnergyPlus/Coils/CoilCoolingDX.cc
Original file line number Diff line number Diff line change
Expand Up @@ -76,13 +76,13 @@ using namespace EnergyPlus;

int CoilCoolingDX::factory(EnergyPlus::EnergyPlusData &state, std::string const &coilName)
{
if (state.dataCoilCooingDX->coilCoolingDXGetInputFlag) {
if (state.dataCoilCoolingDX->coilCoolingDXGetInputFlag) {
CoilCoolingDX::getInput(state);
state.dataCoilCooingDX->coilCoolingDXGetInputFlag = false;
state.dataCoilCoolingDX->coilCoolingDXGetInputFlag = false;
}
int handle = -1;
std::string coilNameUpper = Util::makeUPPER(coilName);
for (auto const &thisCoil : state.dataCoilCooingDX->coilCoolingDXs) {
for (auto const &thisCoil : state.dataCoilCoolingDX->coilCoolingDXs) {
handle++;
if (coilNameUpper == Util::makeUPPER(thisCoil.name)) {
return handle;
Expand All @@ -94,7 +94,7 @@ int CoilCoolingDX::factory(EnergyPlus::EnergyPlusData &state, std::string const

void CoilCoolingDX::getInput(EnergyPlusData &state)
{
int numCoolingCoilDXs = state.dataInputProcessing->inputProcessor->getNumObjectsFound(state, state.dataCoilCooingDX->coilCoolingDXObjectName);
int numCoolingCoilDXs = state.dataInputProcessing->inputProcessor->getNumObjectsFound(state, state.dataCoilCoolingDX->coilCoolingDXObjectName);
if (numCoolingCoilDXs <= 0) {
ShowFatalError(state, R"(No "Coil:Cooling:DX" objects in input file)");
}
Expand All @@ -103,7 +103,7 @@ void CoilCoolingDX::getInput(EnergyPlusData &state)
int NumNumbers; // Number of Numbers for each GetObjectItem call
int IOStatus;
state.dataInputProcessing->inputProcessor->getObjectItem(state,
state.dataCoilCooingDX->coilCoolingDXObjectName,
state.dataCoilCoolingDX->coilCoolingDXObjectName,
coilNum,
state.dataIPShortCut->cAlphaArgs,
NumAlphas,
Expand All @@ -123,7 +123,7 @@ void CoilCoolingDX::getInput(EnergyPlusData &state)
input_specs.evaporative_condenser_supply_water_storage_tank_name = state.dataIPShortCut->cAlphaArgs(10);
CoilCoolingDX thisCoil;
thisCoil.instantiateFromInputSpec(state, input_specs);
state.dataCoilCooingDX->coilCoolingDXs.push_back(thisCoil);
state.dataCoilCoolingDX->coilCoolingDXs.push_back(thisCoil);
}
}

Expand All @@ -136,7 +136,7 @@ void CoilCoolingDX::instantiateFromInputSpec(EnergyPlusData &state, const CoilCo

// initialize reclaim heat parameters
this->reclaimHeat.Name = this->name;
this->reclaimHeat.SourceType = state.dataCoilCooingDX->coilCoolingDXObjectName;
this->reclaimHeat.SourceType = state.dataCoilCoolingDX->coilCoolingDXObjectName;

this->performance = CoilCoolingDXCurveFitPerformance(state, input_data.performance_object_name);

Expand Down Expand Up @@ -189,7 +189,7 @@ void CoilCoolingDX::instantiateFromInputSpec(EnergyPlusData &state, const CoilCo
if (!input_data.condensate_collection_water_storage_tank_name.empty()) {
WaterManager::SetupTankSupplyComponent(state,
this->name,
state.dataCoilCooingDX->coilCoolingDXObjectName,
state.dataCoilCoolingDX->coilCoolingDXObjectName,
input_data.condensate_collection_water_storage_tank_name,
errorsFound,
this->condensateTankIndex,
Expand All @@ -199,7 +199,7 @@ void CoilCoolingDX::instantiateFromInputSpec(EnergyPlusData &state, const CoilCo
if (!input_data.evaporative_condenser_supply_water_storage_tank_name.empty()) {
WaterManager::SetupTankDemandComponent(state,
this->name,
state.dataCoilCooingDX->coilCoolingDXObjectName,
state.dataCoilCoolingDX->coilCoolingDXObjectName,
input_data.evaporative_condenser_supply_water_storage_tank_name,
errorsFound,
this->evaporativeCondSupplyTankIndex,
Expand All @@ -213,7 +213,7 @@ void CoilCoolingDX::instantiateFromInputSpec(EnergyPlusData &state, const CoilCo
}

if (this->availScheduleIndex == 0) {
ShowSevereError(state, std::string{routineName} + state.dataCoilCooingDX->coilCoolingDXObjectName + "=\"" + this->name + "\", invalid");
ShowSevereError(state, std::string{routineName} + state.dataCoilCoolingDX->coilCoolingDXObjectName + "=\"" + this->name + "\", invalid");
ShowContinueError(state, "...Availability Schedule Name=\"" + input_data.availability_schedule_name + "\".");
errorsFound = true;
}
Expand All @@ -224,15 +224,15 @@ void CoilCoolingDX::instantiateFromInputSpec(EnergyPlusData &state, const CoilCo
}

BranchNodeConnections::TestCompSet(state,
state.dataCoilCooingDX->coilCoolingDXObjectName,
state.dataCoilCoolingDX->coilCoolingDXObjectName,
this->name,
input_data.evaporator_inlet_node_name,
input_data.evaporator_outlet_node_name,
"Air Nodes");

if (errorsFound) {
ShowFatalError(state,
std::string{routineName} + "Errors found in getting " + state.dataCoilCooingDX->coilCoolingDXObjectName +
std::string{routineName} + "Errors found in getting " + state.dataCoilCoolingDX->coilCoolingDXObjectName +
" input. Preceding condition(s) causes termination.");
}
}
Expand Down Expand Up @@ -805,7 +805,7 @@ void CoilCoolingDX::simulate(EnergyPlusData &state,
ratedSensCap = this->performance.normalMode.ratedGrossTotalCap * this->normModeNomSpeed().grossRatedSHR;
state.dataRptCoilSelection->coilSelectionReportObj->setCoilFinalSizes(state,
this->name,
state.dataCoilCooingDX->coilCoolingDXObjectName,
state.dataCoilCoolingDX->coilCoolingDXObjectName,
this->performance.normalMode.ratedGrossTotalCap,
ratedSensCap,
this->performance.normalMode.ratedEvapAirFlowRate,
Expand All @@ -816,7 +816,7 @@ void CoilCoolingDX::simulate(EnergyPlusData &state,
if (this->supplyFanIndex > 0) {
state.dataRptCoilSelection->coilSelectionReportObj->setCoilSupplyFanInfo(state,
this->name,
state.dataCoilCooingDX->coilCoolingDXObjectName,
state.dataCoilCoolingDX->coilCoolingDXObjectName,
state.dataFans->fans(this->supplyFanIndex)->Name,
state.dataFans->fans(this->supplyFanIndex)->type,
this->supplyFanIndex);
Expand Down Expand Up @@ -903,7 +903,7 @@ void CoilCoolingDX::simulate(EnergyPlusData &state,
state, dummyEvapOutlet.Temp, dummyEvapOutlet.HumRat, DataEnvironment::StdPressureSeaLevel, "Coil:Cooling:DX::simulate");
state.dataRptCoilSelection->coilSelectionReportObj->setRatedCoilConditions(state,
this->name,
state.dataCoilCooingDX->coilCoolingDXObjectName,
state.dataCoilCoolingDX->coilCoolingDXObjectName,
coolingRate,
sensCoolingRate,
ratedInletEvapMassFlowRate,
Expand Down Expand Up @@ -987,7 +987,7 @@ void PopulateCoolingCoilStandardRatingInformation(InputOutputFile &eio,

void CoilCoolingDX::reportAllStandardRatings(EnergyPlusData &state)
{
if (!state.dataCoilCooingDX->coilCoolingDXs.empty()) {
if (!state.dataCoilCoolingDX->coilCoolingDXs.empty()) {
Real64 constexpr ConvFromSIToIP(3.412141633); // Conversion from SI to IP [3.412 Btu/hr-W]
if (state.dataHVACGlobal->StandardRatingsMyCoolOneTimeFlag) {
static constexpr std::string_view Format_994(
Expand All @@ -998,7 +998,7 @@ void CoilCoolingDX::reportAllStandardRatings(EnergyPlusData &state)
print(state.files.eio, "{}\n", Format_994);
state.dataHVACGlobal->StandardRatingsMyCoolOneTimeFlag = false;
}
for (auto &coil : state.dataCoilCooingDX->coilCoolingDXs) {
for (auto &coil : state.dataCoilCoolingDX->coilCoolingDXs) {
coil.performance.calcStandardRatings210240(state);
PopulateCoolingCoilStandardRatingInformation(state.files.eio,
coil.name,
Expand Down Expand Up @@ -1141,5 +1141,5 @@ void CoilCoolingDX::reportAllStandardRatings(EnergyPlusData &state)
"4 - Value for the Full Speed of the coil.");
}
}
state.dataCoilCooingDX->stillNeedToReportStandardRatings = false;
state.dataCoilCoolingDX->stillNeedToReportStandardRatings = false;
}
Loading

0 comments on commit 701f4ba

Please sign in to comment.