Skip to content

Commit

Permalink
remove name tag in the comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Yujie Xu committed Mar 8, 2024
1 parent a8cef58 commit 7a38358
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions src/EnergyPlus/HVACVariableRefrigerantFlow.cc
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ void SimulateVRF(EnergyPlusData &state,
if (state.dataHVACVarRefFlow->VRF(VRFCondenser).CondenserType == DataHeatBalance::RefrigCondenserType::Water)
UpdateVRFCondenser(state, VRFCondenser);
}
// yujie: update coil and IU evaporating temperature, also keep coil RTF updated with the condenser side cycling ratio, for the FluidTCtrl model
// update coil and IU evaporating temperature, also keep coil RTF updated with the condenser side cycling ratio, for the FluidTCtrl model
if (state.dataHVACVarRefFlow->VRF(VRFCondenser).VRFAlgorithmType == AlgorithmType::FluidTCtrl) {
if (state.dataHVACVarRefFlow->VRF(VRFCondenser).adjustedTe && (!FirstHVACIteration)) {
state.dataDXCoils->DXCoil(state.dataHVACVarRefFlow->VRFTU(VRFTUNum).CoolCoilIndex).EvaporatingTemp =
Expand Down Expand Up @@ -12204,7 +12204,7 @@ void VRFCondenserEquipment::CalcVRFCondenser_FluidTCtrl(EnergyPlusData &state)

this->HeatingCapacity = 0.0; // Include the piping loss
this->PipingCorrectionHeating = 1.0; // 1 means no piping loss
state.dataHVACVarRefFlow->MaxHeatingCapacity(VRFCond) = MaxCap; // yujie: default value is MaxCap = 1e+20, not 0
state.dataHVACVarRefFlow->MaxHeatingCapacity(VRFCond) = MaxCap; // default value is MaxCap = 1e+20, not 0

this->CoolingCapacity = 0.0; // Include the piping loss
this->PipingCorrectionCooling = 1.0;
Expand Down Expand Up @@ -14277,7 +14277,7 @@ void VRFCondenserEquipment::VRFOU_CalcCompC(EnergyPlusData &state,
MinOutdoorUnitPe = max(P_discharge - this->CompMaxDeltaP, MinRefriPe);
MinOutdoorUnitTe = GetSatTemperatureRefrig(
state, this->RefrigerantName, max(min(MinOutdoorUnitPe, RefPHigh), RefPLow), RefrigerantIndex, RoutineName);
// yujie: Te can't be smaller than user input lower bound
// Te can't be smaller than user input lower bound
MinOutdoorUnitTe = max(this->IUEvapTempLow, MinOutdoorUnitTe);

auto f = [&state, T_discharge_new, CondHeat, CAPFT](Real64 const T_suc) {
Expand Down
2 changes: 1 addition & 1 deletion src/EnergyPlus/HeatBalanceSurfaceManager.cc
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ void InitSurfaceHeatBalance(EnergyPlusData &state)
}
}

// yujie: variable thermal solar absorptance overrides
// variable thermal solar absorptance overrides
UpdateVariableAbsorptances(state);

// Do the Begin Environment initializations
Expand Down
2 changes: 1 addition & 1 deletion src/EnergyPlus/HeatRecovery.cc
Original file line number Diff line number Diff line change
Expand Up @@ -513,7 +513,7 @@ namespace HeatRecovery {
thisExchanger.EconoLockOut = static_cast<bool>(toggle);
}

// yujie: read new curves here
// read new curves here
thisExchanger.HeatEffectSensibleCurveIndex =
Curve::GetCurveIndex(state, state.dataIPShortCut->cAlphaArgs(11)); // convert curve name to number
thisExchanger.HeatEffectLatentCurveIndex =
Expand Down
2 changes: 1 addition & 1 deletion src/EnergyPlus/Material.cc
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ void GetMaterialData(EnergyPlusData &state, bool &ErrorsFound) // set to true if
state.dataMaterial->TotMaterials += 1 + TotFfactorConstructs + TotCfactorConstructs;
}

// yujie: This looks kind of silly, but we need it to keep the Materials array in IDF order.
// This looks kind of silly, but we need it to keep the Materials array in IDF order.
for (int i = 1; i <= state.dataMaterial->TotMaterials; i++) {
MaterialBase *p = new MaterialBase;
state.dataMaterial->Material.push_back(p);
Expand Down

5 comments on commit 7a38358

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vrfFluidCtrlFixCoolingCycling (Unknown) - Win64-Windows-10-VisualStudio-16: OK (2765 of 2766 tests passed, 0 test warnings)

Failures:\n

EnergyPlusFixture Test Summary

  • Passed: 1486
  • Failed: 1

Build Badge Test Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vrfFluidCtrlFixCoolingCycling (Unknown) - x86_64-MacOS-10.18-clang-15.0.0: OK (3548 of 3554 tests passed, 0 test warnings)

Messages:\n

  • 4 tests had: ESO big diffs.
  • 4 tests had: Table big diffs.
  • 3 tests had: EIO diffs.
  • 3 tests had: ERR diffs.
  • 2 tests had: MTR big diffs.

Failures:\n

EnergyPlusFixture Test Summary

  • Passed: 1488
  • Failed: 1

regression Test Summary

  • Passed: 783
  • Failed: 4

Build Badge Test Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vrfFluidCtrlFixCoolingCycling (Unknown) - x86_64-Linux-Ubuntu-22.04-gcc-11.4: OK (3590 of 3595 tests passed, 0 test warnings)

Messages:\n

  • 4 tests had: ESO big diffs.
  • 4 tests had: Table big diffs.
  • 3 tests had: EIO diffs.
  • 3 tests had: ERR diffs.
  • 2 tests had: MTR big diffs.

Failures:\n

EnergyPlusFixture Test Summary

  • Passed: 1488
  • Failed: 1

regression Test Summary

  • Passed: 803
  • Failed: 4

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vrfFluidCtrlFixCoolingCycling (Unknown) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-UnitTestsCoverage-Debug: OK (1977 of 1978 tests passed, 0 test warnings)

Failures:\n

EnergyPlusFixture Test Summary

  • Passed: 1488
  • Failed: 1

Build Badge Test Badge Coverage Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vrfFluidCtrlFixCoolingCycling (Unknown) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-IntegrationCoverage-Debug: OK (791 of 791 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

Please sign in to comment.