Skip to content

Commit

Permalink
Revert "Set Mass flow Rate"
Browse files Browse the repository at this point in the history
This reverts uneeded bits from commit 3eb34cf (discovered that if I trigger the unit test in the right order, and call initialize after a first size() call, the mass flow rates are properly set and reported)
  • Loading branch information
jmarrec committed Jan 28, 2025
1 parent 3eb34cf commit eb331c0
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions src/EnergyPlus/ChillerElectricEIR.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1682,18 +1682,10 @@ void ElectricEIRChillerSpecs::size(EnergyPlusData &state)
OutputReportPredefined::PreDefTableEntry(state, state.dataOutRptPredefined->pdchChillerRefEntCondTemp, this->Name, this->TempRefCondIn);
OutputReportPredefined::PreDefTableEntry(state, state.dataOutRptPredefined->pdchChillerRefLevEvapTemp, this->Name, this->TempRefEvapOut);

{
Real64 const rho = state.dataPlnt->PlantLoop(this->CWPlantLoc.loopNum).glycol->getDensity(state, Constant::CWInitConvTemp, RoutineName);
this->EvapMassFlowRateMax = this->EvapVolFlowRate * rho;
}
OutputReportPredefined::PreDefTableEntry(state,
state.dataOutRptPredefined->pdchChillerDesSizeRefCHWFlowRate,
this->Name,
this->EvapMassFlowRateMax); // flowrate Max==DesignSizeRef flowrate?
if (this->CondenserType == DataPlant::CondenserType::WaterCooled) {
Real64 const rho = state.dataPlnt->PlantLoop(this->CDPlantLoc.loopNum).glycol->getDensity(state, this->TempRefCondIn, RoutineName);
this->CondMassFlowRateMax = this->CondVolFlowRate * rho;
}
OutputReportPredefined::PreDefTableEntry(state,
state.dataOutRptPredefined->pdchChillerDesSizeRefCondFluidFlowRate,
this->Name,
Expand Down

3 comments on commit eb331c0

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10888_ChillerMinPLRReport (jmarrec) - x86_64-Linux-Ubuntu-24.04-gcc-13.3-UnitTestsCoverage-RelWithDebInfo: OK (2104 of 2104 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10888_ChillerMinPLRReport (jmarrec) - x86_64-Linux-Ubuntu-24.04-gcc-13.3: OK (2923 of 2923 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10888_ChillerMinPLRReport (jmarrec) - x86_64-Linux-Ubuntu-24.04-gcc-13.3-IntegrationCoverage-RelWithDebInfo: OK (802 of 802 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

Please sign in to comment.