Fixing cooling mode cooling coil cooling rate much higher than heat pump cooling rate and OU capacity #10557
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1479,8 +1479,8 @@ void GetVRFInputData(EnergyPlusData &state, bool &ErrorsFound) | |
| state.dataHVACVarRefFlow->MaxHeatingCapacity.allocate(state.dataHVACVarRefFlow->NumVRFCond); | ||
| state.dataHVACVarRefFlow->CoolCombinationRatio.allocate(state.dataHVACVarRefFlow->NumVRFCond); | ||
| state.dataHVACVarRefFlow->HeatCombinationRatio.allocate(state.dataHVACVarRefFlow->NumVRFCond); | ||
| state.dataHVACVarRefFlow->MaxCoolingCapacity = Constant::MaxCap; | ||
| state.dataHVACVarRefFlow->MaxHeatingCapacity = Constant::MaxCap; | ||
| state.dataHVACVarRefFlow->CoolCombinationRatio = 1.0; | ||
| state.dataHVACVarRefFlow->HeatCombinationRatio = 1.0; | ||
| } | ||
|
|
@@ -6589,8 +6589,8 @@ void InitVRF(EnergyPlusData &state, int const VRFTUNum, int const ZoneNum, bool | |
| // terminal unit will be limited to 3-tons (see SimVRFCondenser where this variable is calculated). | ||
| if (CurrentEndTime > state.dataHVACVarRefFlow->CurrentEndTimeLast || TimeStepSysLast > state.dataHVACGlobal->TimeStepSys || | ||
| (FirstHVACIteration && state.dataHVACVarRefFlow->MyBeginTimeStepFlag(VRFCond))) { | ||
| state.dataHVACVarRefFlow->MaxCoolingCapacity(VRFCond) = Constant::MaxCap; | ||
| state.dataHVACVarRefFlow->MaxHeatingCapacity(VRFCond) = Constant::MaxCap; | ||
| state.dataHVACVarRefFlow->MyBeginTimeStepFlag(VRFCond) = false; | ||
| } | ||
|
|
||
|
|
@@ -9601,8 +9601,10 @@ void VRFTerminalUnitEquipment::CalcVRF(EnergyPlusData &state, | |
| } | ||
| } | ||
| // calculate sensible load met using delta enthalpy | ||
| Real64 TotalOutput = AirMassFlow * (Psychrometrics::PsyHFnTdbW(TempOut, SpecHumOut) - | ||
| Psychrometrics::PsyHFnTdbW(TempIn, SpecHumIn)); // total addition/removal rate, {W}; | ||
| LoadMet = AirMassFlow * PsyDeltaHSenFnTdb2W2Tdb1W1(TempOut, SpecHumOut, TempIn, SpecHumIn); // sensible {W} | ||
| LatentLoadMet = TotalOutput - LoadMet; | ||
| if (present(LatOutputProvided)) { | ||
| // CR9155 Remove specific humidity calculations | ||
| LatOutputProvided = LatentLoadMet; | ||
|
|
@@ -9748,10 +9750,7 @@ void ReportVRFTerminalUnit(EnergyPlusData &state, int const VRFTUNum) // index t | |
| TempOut = state.dataLoopNodes->Node(state.dataHVACVarRefFlow->VRFTU(VRFTUNum).VRFTUOutletNodeNum).Temp; | ||
| TempIn = state.dataLoopNodes->Node(state.dataHVACVarRefFlow->VRFTU(VRFTUNum).VRFTUInletNodeNum).Temp; | ||
| } | ||
| TotalConditioning = SensibleConditioning + LatentConditioning; | ||
|
|
||
| if (TotalConditioning <= 0.0) { | ||
| state.dataHVACVarRefFlow->VRFTU(VRFTUNum).TotalCoolingRate = std::abs(TotalConditioning); | ||
|
|
@@ -9768,11 +9767,11 @@ void ReportVRFTerminalUnit(EnergyPlusData &state, int const VRFTUNum) // index t | |
| state.dataHVACVarRefFlow->VRFTU(VRFTUNum).SensibleHeatingRate = SensibleConditioning; | ||
| } | ||
| if (LatentConditioning <= 0.0) { | ||
| state.dataHVACVarRefFlow->VRFTU(VRFTUNum).LatentCoolingRate = std::abs(LatentConditioning); | ||
| state.dataHVACVarRefFlow->VRFTU(VRFTUNum).LatentHeatingRate = 0.0; | ||
| } else { | ||
| state.dataHVACVarRefFlow->VRFTU(VRFTUNum).LatentCoolingRate = 0.0; | ||
| state.dataHVACVarRefFlow->VRFTU(VRFTUNum).LatentHeatingRate = LatentConditioning; | ||
| } | ||
| state.dataHVACVarRefFlow->VRFTU(VRFTUNum).TotalCoolingEnergy = state.dataHVACVarRefFlow->VRFTU(VRFTUNum).TotalCoolingRate * ReportingConstant; | ||
| state.dataHVACVarRefFlow->VRFTU(VRFTUNum).SensibleCoolingEnergy = | ||
|
|
@@ -10571,15 +10570,15 @@ void LimitCoilCapacity(int const NumTUInList, // Number of terminal un | |
|
|
||
| // sort TU capacity from lowest to highest | ||
| for (TempTUIndex = 1; TempTUIndex <= NumTUInList; ++TempTUIndex) { | ||
| MinOutput = Constant::MaxCap; | ||
| for (NumTU = 1; NumTU <= NumTUInList; ++NumTU) { | ||
| if (Temp2(NumTU) < MinOutput) { | ||
| MinOutput = Temp2(NumTU); | ||
| Temp(TempTUIndex) = MinOutput; | ||
| MinOutputIndex = NumTU; | ||
| } | ||
| } | ||
| Temp2(MinOutputIndex) = Constant::MaxCap; | ||
| } | ||
|
|
||
| // find limit of "terminal unit" capacity so that sum of all TU's does not exceed condenser capacity | ||
|
|
@@ -11367,9 +11366,6 @@ void VRFCondenserEquipment::CalcVRFCondenser_FluidTCtrl(EnergyPlusData &state, c | |
| if (Q_c_TU_PL > CompEvaporatingCAPSpdMax) { | ||
| // Required load is beyond the max system capacity | ||
|
|
||
|
There was a problem hiding this comment. Should TU_CoolingLoad be reset here or not? This var is used at line 11385 below. For a VRF system with 1 TU this might make sense but for multiple TUs this will likely have no impact. There was a problem hiding this comment. It shouldn't be reset here. Similar to the situation in the heating side, which we fixed a while ago: #10154 This upper bounding will cause the compressor to reduce its output at more extreme weather, which is bad. So this upper bounding needs to be removed. |
||
| RefTSat = this->refrig->getSatTemperature(state, max(min(Pevap, RefPHigh), RefPLow), RoutineName); | ||
| h_IU_evap_out = | ||
| this->refrig->getSupHeatEnthalpy(state, max(RefTSat, this->IUEvaporatingTemp + 3), max(min(Pevap, RefPHigh), RefPLow), RoutineName); | ||
|
|
@@ -11503,7 +11499,7 @@ void VRFCondenserEquipment::CalcVRFCondenser_FluidTCtrl(EnergyPlusData &state, c | |
|
|
||
| this->HeatingCapacity = 0.0; // Include the piping loss | ||
| this->PipingCorrectionHeating = 1.0; // 1 means no piping loss | ||
| state.dataHVACVarRefFlow->MaxHeatingCapacity(VRFCond) = Constant::MaxCap; | ||
|
|
||
| this->OUCondHeatRate = Q_h_OU; | ||
| this->OUEvapHeatRate = 0; | ||
|
|
@@ -11720,8 +11716,8 @@ void VRFCondenserEquipment::CalcVRFCondenser_FluidTCtrl(EnergyPlusData &state, c | |
| this->HeatingCapacity; // for report, maximum condensing capacity the system can provide | ||
|
|
||
| this->CoolingCapacity = 0.0; // Include the piping loss | ||
| this->PipingCorrectionCooling = 1.0; | ||
| state.dataHVACVarRefFlow->MaxCoolingCapacity(VRFCond) = Constant::MaxCap; // for report | ||
|
|
||
| this->OUCondHeatRate = 0; | ||
| this->OUEvapHeatRate = Q_c_OU; | ||
|
|
@@ -11957,13 +11953,13 @@ void VRFCondenserEquipment::CalcVRFCondenser_FluidTCtrl(EnergyPlusData &state, c | |
| this->OUFanPower = 0.0; | ||
| this->VRFCondCyclingRatio = 0.0; | ||
|
|
||
| this->HeatingCapacity = 0.0; // Include the piping loss | ||
| this->PipingCorrectionHeating = 1.0; // 1 means no piping loss | ||
| state.dataHVACVarRefFlow->MaxHeatingCapacity(VRFCond) = Constant::MaxCap; // yujie: default value is MaxCap = 1e+20, not 0 | ||
|
|
||
| this->CoolingCapacity = 0.0; // Include the piping loss | ||
| this->PipingCorrectionCooling = 1.0; | ||
| state.dataHVACVarRefFlow->MaxCoolingCapacity(VRFCond) = Constant::MaxCap; // for report | ||
|
|
||
| this->CondensingTemp = state.dataEnvrn->OutDryBulbTemp; | ||
| this->EvaporatingTemp = state.dataEnvrn->OutDryBulbTemp; | ||
|
|
@@ -12718,7 +12714,7 @@ void VRFTerminalUnitEquipment::CalcVRF_FluidTCtrl(EnergyPlusData &state, | |
| state.dataHVACVarRefFlow->CompOffMassFlow = state.dataHVACVarRefFlow->OACompOffMassFlow; | ||
| } else { | ||
| // identify the air flow rate corresponding to the coil load | ||
| if (this->HeatingCoilPresent && state.dataHVACVarRefFlow->MaxHeatingCapacity(VRFCond) < Constant::MaxCap) { | ||
| // Only fix heating only mode for now | ||
| state.dataHVACVarRefFlow->CompOnMassFlow = CalVRFTUAirFlowRate_FluidTCtrl( | ||
| state, VRFTUNum, PartLoadRatio, FirstHVACIteration, state.dataHVACVarRefFlow->MaxHeatingCapacity(VRFCond)); | ||
|
|
@@ -12867,8 +12863,10 @@ void VRFTerminalUnitEquipment::CalcVRF_FluidTCtrl(EnergyPlusData &state, | |
| } | ||
| } | ||
| // calculate sensible load met using delta enthalpy | ||
| Real64 TotalOutput = AirMassFlow * (Psychrometrics::PsyHFnTdbW(TempOut, SpecHumOut) - | ||
| Psychrometrics::PsyHFnTdbW(TempIn, SpecHumIn)); // total addition/removal rate, {W}; | ||
| LoadMet = AirMassFlow * PsyDeltaHSenFnTdb2W2Tdb1W1(TempOut, SpecHumOut, TempIn, SpecHumIn); // sensible {W} | ||
| LatentLoadMet = TotalOutput - LoadMet; | ||
| if (present(LatOutputProvided)) { | ||
| LatOutputProvided = LatentLoadMet; | ||
| } | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -107,8 +107,6 @@ namespace HVACVariableRefrigerantFlow { | |
| Num | ||
| }; | ||
|
|
||
| // VRF Algorithm Type | ||
| enum class AlgorithmType | ||
| { | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why the max capacity is not always passed into the coil. It's either 1.0e+20 or it's a value. That's for another day.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just changed MaxCoolCap to regular non-optional arguments. @rraustad