Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand Series Active Branch Logic in SetComponentFlowRate #10808

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Expand Series Active Branch Logic in SetComponentFlowRate #10808

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c78535
Expand Series Active Branch Logic in SetComponentFlowRate
EnergyArchmage Oct 30, 2024
b51c768
revise SeriesActive change in SetComponentFlowRate to only be for sup…
EnergyArchmage Dec 18, 2024
78a72fa
Merge branch 'develop' into SetComponentFlowRate-series-active-change
EnergyArchmage Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/EnergyPlus/PlantUtilities.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,14 @@ void SetComponentFlowRate(EnergyPlusData &state,
Real64 const MdotOldRequest = state.dataLoopNodes->Node(InletNode).MassFlowRateRequest;
auto &loop_side = state.dataPlnt->PlantLoop(plantLoc.loopNum).LoopSide(plantLoc.loopSideNum);
auto const &comp = loop_side.Branch(plantLoc.branchNum).Comp(plantLoc.compNum);

if (DataPlant::CompData::getPlantComponent(state, plantLoc).FlowCtrl == DataBranchAirLoopPlant::ControlType::SeriesActive &&
plantLoc.loopSideNum == DataPlant::LoopSideLocation::Supply) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added supply side to logic check so new behavior doesn't impact coils in series. Found that in UnitarySystem, early calls to check the max capacity of a coil with full water flow were setting up flow that then would not get shut down with the change.

Real64 seriesFlowVal = state.dataLoopNodes->Node(DataPlant::CompData::getPlantComponent(state, plantLoc).NodeNumIn).MassFlowRate;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EnergyArchmage What about downstream components on a series active branch. For example, 2 chillers in series, the first chiller is off, but the second chiller is on. How does the first chiller find out there should be flow on the branch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That situation is the main point the change is trying to address. The beginning iteration there isn't any flow yet, so yes, the first chiller is off and doesn't see any flow on the node. But the next iteration, the second chiller will come on and make a flow request, and if flow gets going then the first chiller will see flow on the node. The idea is for the first chiller to not keep requesting zero flow even when there is flow. That zero request seems to set up a fight between a zero flow request and some flow and isn't helpful when we know there is already flow. Series active branches are supposed to look at the last node on the branch but it seems that design is not completely implemented and mismatched flow requests on upstream nodes can cause problems, like more iterations before things settle down.

Copy link
Contributor

@rraustad rraustad Nov 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use if (comp.FlowCtrl == DataBranchAirLoopPlant::ControlType::SeriesActive) on line 152 and comp.NodeNumIn on line 153

CompData &CompData::getPlantComponent(EnergyPlusData &state, PlantLocation const &plantLoc)
{
    return state.dataPlnt->PlantLoop(plantLoc.loopNum).LoopSide(plantLoc.loopSideNum).Branch(plantLoc.branchNum).Comp(plantLoc.compNum);
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasn't clear to me if that "comp" is a real pointer

// we don't want to setup a zero MassFlowRateRequest if there is already flow in a series active branch.
if (CompFlow == 0.0 && seriesFlowVal > DataBranchAirLoopPlant::MassFlowTolerance) {
CompFlow = seriesFlowVal;
}
}
if (comp.CurOpSchemeType == DataPlant::OpScheme::Demand) {
// store flow request on inlet node
state.dataLoopNodes->Node(InletNode).MassFlowRateRequest = CompFlow;
Expand Down
Loading