Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Typo cooing -> cooling #10905

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[chore] Typo cooing -> cooling #10905

wants to merge 2 commits into from

Conversation

jmarrec
Copy link
Contributor

@jmarrec jmarrec commented Jan 23, 2025

Pull request overview

  • Typo cooing -> cooling
  • Update .git-blame-ignore-revs, adding in particular the commits that updated the license text to 2025

@jmarrec jmarrec added DoNotPublish Includes changes that shouldn't be reported in the changelog Developer Issue Related to cmake, packaging, installers, or developer tooling (CI, etc) labels Jan 23, 2025
@@ -338,7 +338,7 @@ struct EnergyPlusData : BaseGlobalStruct
std::unique_ptr<ChillerIndirectAbsoprtionData> dataChillerIndirectAbsorption;
std::unique_ptr<ChillerReformulatedEIRData> dataChillerReformulatedEIR;
std::unique_ptr<ChillerElectricASHRAE205Data> dataChillerElectricASHRAE205;
std::unique_ptr<CoilCoolingDXData> dataCoilCooingDX;
std::unique_ptr<CoilCoolingDXData> dataCoilCoolingDX;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's pretty much it

Comment on lines 528 to 530
# [chore] Typo cooing -> cooling [Julien Marrec, 2025-01-23]
951068c8da7dce7767cd42404b66ba503ed34367
# 25 files changed, 125 insertions(+), 125 deletions(-)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore that commit when blaming.

Comment on lines +257 to +258
# Merge pull request #10886 from NREL/update-license-year-2025 [Edwin Lee, 2025-01-08]
b46ced64a420a7df09af0f301499d0548ac89966
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update .git-blame-ignore-revs a bit, especially removing the commits that update the license file as they show on every blame you do otherwise

@jmarrec jmarrec requested a review from Myoldmopar January 23, 2025 10:14
```bash
rg dataCoilCooingDX -l | xargs -I @ sed -i 's/dataCoilCooingDX/dataCoilCoolingDX/g' @
rg cooing -l | xargs -I @ sed -i 's/cooing/cooling/g' @
rg Cooing -l | xargs -I @ sed -i 's/Cooing/Cooling/g' @
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Developer Issue Related to cmake, packaging, installers, or developer tooling (CI, etc) DoNotPublish Includes changes that shouldn't be reported in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants