No longer setting CurrentUnits = PreferredUnits (issue 95) #307
Conversation
| @@ -4,7 +4,7 @@ | |||
| Reservoir Model, 1 | |||
| Reservoir Volume Option, 1 | |||
| Reservoir Density, 2800 | |||
| Reservoir Depth, 8500 feet, -- https://pangea.stanford.edu/ERE/db/GeoConf/papers/SGW/2024/Fercho.pdf | |||
There was a problem hiding this comment.
This would be a backwards-incompatible change - can we preserve feet as a valid unit?
There was a problem hiding this comment.
If I understand the Units classes correctly, a given unit can have only one value (e.g., in LengthUnit, the value for FEET is "ft"). The only way I see to allow multiple values for a given unit would be to add a special case into LookupUnits, but this strikes me as a hack. Is there another (or a better) way?
There was a problem hiding this comment.
We might be able to add an entry in https://github.com/NREL/GEOPHIRES-X/blob/main/src/geophires_x/GEOPHIRES3_newunits.txt
There was a problem hiding this comment.
Actions are failing - looks like example output(s) need to be regenerated to include percent unit (which is a good thing) https://github.com/NREL/GEOPHIRES-X/actions/runs/11769618204/job/32780887255?pr=307#step:5:314
|
Note: this was closed in favor of #310 |
This should fix #95. Note that examples with input units specified as "feet" were changed to "ft" for compatibility with Units.py.